Re: [PATCH 0/6] kbuild configuration system improvements

Sam Ravnborg
2009-07-22T21:48:43Z

On Wed, Jul 22, 2009 at 01:43:21PM -0700, Randy Dunlap wrote:
> On Sat, 18 Jul 2009 09:21:38 +0200 Sam Ravnborg wrote:
>
> > On Sun, Jul 12, 2009 at 04:11:42PM +0800, Cheng Renquan wrote:
> > > From: Cheng Renquan <crquan@gmail.com>
> > >
> > > These patches improve usability of kernel configuration system,
> > >
> > > 1. add symbol's value shown accompanied in config item's help message;
> > > 2. move the real plumbing functions code from mconf.c to menu.c, make them
> > > be able to be shared with other configuration methods;
> > > 3. add "symbol's value shown" support for gconfig/xconfig/config;
> > >
> > > 0001-add-symbol-value-to-help-find-the-real-depend.patch
> > > 0002-add-menu_get_ext_help-function-to-display-more-infor.patch
> > > 0003-menuconfig-improvements.patch
> > > 0004-make-use-of-menu_get_ext_help-in-gconfig.patch
> > > 0005-make-use-of-menu_get_ext_help-in-qconfig.patch
> > > 0006-make-use-of-menu_get_ext_help-in-make-config.patch
> >
> > I fixed them all up to:
> > 1) include "kconfig:" prefix in subject
> > 2) cc: of Roman Zippel which is kconfig maintainer
> >
> > There were a few checkpatch issues that I decided to ignore for now.
> >
> > Please always cc: Roman on kconfig patches as he is the mintainer.
> >
> > Applied to kbuild-next.git.
>
>
> FWIW, I still get a segfault in gconfig (as I reported several months ago).
> I suppose that if it's a real issue, someone else will also see this.

I assumed it was fixed - the changelog patches did
not mention any outstanding issues.

Following fix is needed.

Sam

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 931d782..b74f746 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -528,5 +528,6 @@ void menu_get_ext_help(struct menu *menu, struct gstr *help)
} else {
str_append(help, nohelp_text);
}
- get_symbol_str(help, sym);
+ if (sym)
+ get_symbol_str(help, sym);
}

>
> ---
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
>