Re: [PATCH 1/4] module: extract __ExPORT_SYMBOL from module.h into mod_export.h

Daniel Walker
2009-09-22T15:55:21Z

On Tue, 2009-09-22 at 16:50 +0100, Alan Jenkins wrote:
> Daniel Walker wrote:
> > On Tue, 2009-09-22 at 14:38 +0100, Alan Jenkins wrote:
> >
> >> +
> >> +struct kernel_symbol
> >> +{
> >> + unsigned long value;
> >> + const char *name;
> >> +};
> >>
> >
> > One relevant checkpatch error above,
> >
> > ERROR: open brace '{' following struct go on the same line
> > #71: FILE: include/linux/mod_export.h:13:
> > +struct kernel_symbol
> > +{
> >
> > You have another similar one in patch 4 ,
> >
> > ERROR: else should follow close brace '}'
> > #99: FILE: kernel/module.c:221:
> > + }
> > + else if (cmp < 0)
> >
> >
> > Could you correct those?
> >
> > Daniel
> >
>
> Sure, thanks. I'll hold off on resending though, in case there are any
> more radical changes needed.

Ok thanks..

Daniel