Re: [PATCH 1/4] module: extract __ExPORT_SYMBOL from module.h into mod_export.h

Alan Jenkins
2009-09-22T14:45:19Z

Sam Ravnborg wrote:
> On Tue, Sep 22, 2009 at 02:38:35PM +0100, Alan Jenkins wrote:
>
>> The new header mod_export.h allows __EXPORT_SYMBOL to be used without
>> pulling in any function or variable declarations. It will be used by
>> the build system to help sort the list of symbols exported by the
>> kernel.
>>
>> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
>> ---
>> include/linux/mod_export.h | 74 ++++++++++++++++++++++++++++++++++++++++++++
>> include/linux/module.h | 63 +------------------------------------
>> 2 files changed, 75 insertions(+), 62 deletions(-)
>> create mode 100644 include/linux/mod_export.h
>>
>> diff --git a/include/linux/mod_export.h b/include/linux/mod_export.h
>> new file mode 100644
>> index 0000000..3c51b9c
>> --- /dev/null
>> +++ b/include/linux/mod_export.h
>> @@ -0,0 +1,74 @@
>> +#ifndef LINUX_MOD_EXPORT_H
>> +#define LINUX_MOD_EXPORT_H
>> +
>> +#include <linux/compiler.h>
>> +#include <asm/module.h>
>>
>
> Do you need this include?
>
> Sam
>
asm/module.h is needed in case the arch sets MODULE_SYMBOL_PREFIX.
(and linux/compiler.h is needed for __used).

Let me know if you think it needs a comment.

Thanks
Alan