Re: [PATCH 06/15] kconfig: implement the `mainmenu' directive

Arnaud Lacombe
2010-09-19T14:53:18Z

Hi,

On Sun, Sep 19, 2010 at 5:42 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Sat, Sep 11, 2010 at 11:51:13AM -0400, Arnaud Lacombe wrote:
>> [...]
>>  %%
>> -input: stmt_list;
>> +input: nl start | start;
>> +
>> +start: mainmenu_stmt stmt_list | stmt_list;
>>
>
> With the above the mainmenu is mandatory.
> So there is no longer a need to explicit give it a promt as
> is done in conf_parse:
>
>        modules_sym->flags |= SYMBOL_AUTO;
>        rootmenu.prompt = menu_add_prompt(P_MENU, "Linux Kernel Configuration", NULL);
>
>
> And if we delete this (now not needed) assignment, we no longer requre
> the patch that silence warning about redefinition of rootmeny prompt.
>
No, it is not mandatory. My first implementation made it mandatory,
but I loosen the requirement after you asked me that it would be nice
not to have it mandatory for simple Kconfig file. Making it that way
also save some trouble on UML, but I'll come back on that later on.

- Arnaud