Re: [PATCH 04/15] kconfig: rephrase help texts/comments not to include the package name

Arnaud Lacombe
2010-09-12T04:04:07Z

Hi,

On Sat, Sep 11, 2010 at 4:22 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Sat, 11 Sep 2010 11:51:11 -0400 Arnaud Lacombe wrote:
>>               if (stat(name, &tmpstat)) {
>>                       fprintf(stderr, _("***\n"
>> -                             "*** You have not yet configured your kernel!\n"
>> -                             "*** (missing kernel config file \"%s\")\n"
>> +                             "*** Configuration file \"%s\" not found!\n"
>>                               "***\n"
>>                               "*** Please run some configurator (e.g. \"make oldconfig\" or\n"
>>                               "*** \"make menuconfig\" or \"make xconfig\").\n"
>
> but these *config program names are OK?
>
I'm not aware of all use cases of `conf'. That said, this case is only
relevant if the expected configuration file does not exist which can
be overridden trivially before running `conf'.

Beside that, typos have been addressed in the updated version of the
branch (I'll send a diff-to-previous shortly) as well as a couple of
other nits I noticed today (mostly compiler warnings). I will not
address the "gkc"/"qconf" issue as they're beyond the scope of this
changeset. I also amended the commit log adding a "Reviewed-by" you.

Thanks for the comments!
- Arnaud