Re: [PATCH 1/2] Kbuild: Treat KBUILD_DEFCONFIG=old as request to use .config as the base

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

On Fri, 2010-10-01 at 16:05 +0200, Michal Marek wrote:
> On 14.9.2010 05:50, Ben Hutchings wrote:
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > This should work as a substitute for Debian's updateoldconfig.
> > 
> > Ben.
> > 
> >  scripts/kconfig/Makefile |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> > index cef3f75..19558a7 100644
> > --- a/scripts/kconfig/Makefile
> > +++ b/scripts/kconfig/Makefile
> > @@ -112,9 +112,13 @@ defconfig: $(obj)/conf
> >  ifeq ($(KBUILD_DEFCONFIG),)
> >  	$< --defconfig $(Kconfig)
> >  else
> > +ifeq ($(KBUILD_DEFCONFIG),old)
> > +	$< --defconfig=.config $(Kconfig)
> > +else
> >  	@echo "*** Default configuration is based on '$(KBUILD_DEFCONFIG)'"
> >  	$(Q)$< --defconfig=arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG) $(Kconfig)
> >  endif
> > +endif
> 
> KBUILD_DEFCONFIG is an internal variable used by arch Makefiles to
> select the defconfig file, it should not be abused for a completely
> different purpose.

OK.

> Also, the same can be achieved with 'make
> oldnoconfig' or 'yes "" | make oldconfig' in older kernels.

'make oldnoconfig' does something different - it answers N to all
questions rather than accepting the default.

'yes "" | make oldconfig' does pretty much what we want, except that
it's noisy.  But personally I don't care that much about it.  Max,
Bastian, do you rely on this target?

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]