From: Namhyung Kim <namhyung@gmail.com>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kbuild@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH] kconfig: don't select 64 bit option on sparc32 all{yes,mod}config
Date: Sat, 23 Oct 2010 00:48:04 +0900 [thread overview]
Message-ID: <1287762484-8154-1-git-send-email-namhyung@gmail.com> (raw)
The SPARC architecture provides 64BIT config option to select
build type and it is set to 1 on ARCH=sparc64 as a default value.
But in case of 32-bit, it is also set to 1 by the allyesconfig
logic, end result would be the same as of sparc64. So I think
it would be better if plain ARCH=sparc all{yes,mod}config do not
set it then we can test 32-bit build by default.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
scripts/kconfig/confdata.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 515253f..9820c77 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -1018,6 +1018,10 @@ void conf_set_all_new_symbols(enum conf_def_mode mode)
break;
}
+ /* Do not set 64 bit option when sparc32 allyesconfig */
+ if (sym->name && strcmp(sym->name, "64BIT") == 0 &&
+ strcmp(getenv("ARCH"), "sparc") == 0)
+ sym->def[S_DEF_USER].tri = no;
}
sym_clear_all_valid();
--
1.7.0.4
next reply other threads:[~2010-10-22 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 15:48 Namhyung Kim [this message]
2010-10-24 22:10 ` [PATCH] kconfig: don't select 64 bit option on sparc32 all{yes,mod}config Michal Marek
2010-10-25 5:48 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287762484-8154-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox