[PATCH] kconfig: do not define AUTOCONF_INCLUDED

[PATCH] kconfig: do not define AUTOCONF_INCLUDED

[Arnaud Lacombe]

AUTOCONF_INCLUDED is not checked is not used within the tree and its parent
header, `autoconf.h', is safe to be re-included.

Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
---
 scripts/kconfig/confdata.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 9df8011..f349bdc 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -833,8 +833,7 @@ int conf_write_autoconf(void)
 		       " * Automatically generated C config: don't edit\n"
 		       " * %s\n"
 		       " * %s"
-		       " */\n"
-		       "#define AUTOCONF_INCLUDED\n",
+		       " */\n",
 		       rootmenu.prompt->text, ctime(&now));
 
 	for_all_symbols(i, sym) {
-- 
1.7.2.30.gc37d7.dirty

Re: [PATCH] kconfig: do not define AUTOCONF_INCLUDED

[Arnaud Lacombe]

Hi,

On Sun, Dec 5, 2010 at 1:31 AM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> AUTOCONF_INCLUDED is not checked is not used within the tree and its parent
> header, `autoconf.h', is safe to be re-included.
>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
>  scripts/kconfig/confdata.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
ping ?

 - Arnaud

> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index 9df8011..f349bdc 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -833,8 +833,7 @@ int conf_write_autoconf(void)
>                       " * Automatically generated C config: don't edit\n"
>                       " * %s\n"
>                       " * %s"
> -                      " */\n"
> -                      "#define AUTOCONF_INCLUDED\n",
> +                      " */\n",
>                       rootmenu.prompt->text, ctime(&now));
>
>        for_all_symbols(i, sym) {
> --
> 1.7.2.30.gc37d7.dirty
>
>

Re: [PATCH] kconfig: do not define AUTOCONF_INCLUDED

[Michal Marek]

On Sun, Dec 05, 2010 at 01:31:57AM -0500, Arnaud Lacombe wrote:
> AUTOCONF_INCLUDED is not checked is not used within the tree and its parent
> header, `autoconf.h', is safe to be re-included.

It could be used by external modules that try to be compatible with
pre-2.6.15 kernels, but the fix is trivial in such case (and I guess
most of them dropped the #include of autoconf.h after it moved from
linux/ to generated/ recently). So I applied this to
kbuild-2.6.git#kconfig, thanks.

Michal