* [PATCH] nconfig: Silence unused return values from wattrset
@ 2011-04-06 22:07 Stephen Boyd
2011-04-18 22:38 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2011-04-06 22:07 UTC (permalink / raw)
To: Michal Marek, Roman Zippel; +Cc: linux-kernel, linux-kbuild, Nir Tzachar
Ignore the return value from wattrset since we ignore the return
value in nconf.gui.c as well.
scripts/kconfig/nconf.c: In function 'print_function_line':
scripts/kconfig/nconf.c:376: warning: value computed is not used
scripts/kconfig/nconf.c:380: warning: value computed is not used
scripts/kconfig/nconf.c:387: warning: value computed is not used
scripts/kconfig/nconf.c: In function 'show_menu':
scripts/kconfig/nconf.c:956: warning: value computed is not used
scripts/kconfig/nconf.c:961: warning: value computed is not used
scripts/kconfig/nconf.c:963: warning: value computed is not used
scripts/kconfig/nconf.c:965: warning: value computed is not used
Cc: Nir Tzachar <nir.tzachar@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
scripts/kconfig/nconf.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index db56377..488dd74 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -373,18 +373,18 @@ static void print_function_line(void)
const int skip = 1;
for (i = 0; i < function_keys_num; i++) {
- wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
+ (void) wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
mvwprintw(main_window, LINES-3, offset,
"%s",
function_keys[i].key_str);
- wattrset(main_window, attributes[FUNCTION_TEXT]);
+ (void) wattrset(main_window, attributes[FUNCTION_TEXT]);
offset += strlen(function_keys[i].key_str);
mvwprintw(main_window, LINES-3,
offset, "%s",
function_keys[i].func);
offset += strlen(function_keys[i].func) + skip;
}
- wattrset(main_window, attributes[NORMAL]);
+ (void) wattrset(main_window, attributes[NORMAL]);
}
/* help */
@@ -953,16 +953,16 @@ static void show_menu(const char *prompt, const char *instructions,
current_instructions = instructions;
clear();
- wattrset(main_window, attributes[NORMAL]);
+ (void) wattrset(main_window, attributes[NORMAL]);
print_in_middle(stdscr, 1, 0, COLS,
menu_backtitle,
attributes[MAIN_HEADING]);
- wattrset(main_window, attributes[MAIN_MENU_BOX]);
+ (void) wattrset(main_window, attributes[MAIN_MENU_BOX]);
box(main_window, 0, 0);
- wattrset(main_window, attributes[MAIN_MENU_HEADING]);
+ (void) wattrset(main_window, attributes[MAIN_MENU_HEADING]);
mvwprintw(main_window, 0, 3, " %s ", prompt);
- wattrset(main_window, attributes[NORMAL]);
+ (void) wattrset(main_window, attributes[NORMAL]);
set_menu_items(curses_menu, curses_menu_items);
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nconfig: Silence unused return values from wattrset
2011-04-06 22:07 [PATCH] nconfig: Silence unused return values from wattrset Stephen Boyd
@ 2011-04-18 22:38 ` Stephen Boyd
2011-04-19 7:22 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2011-04-18 22:38 UTC (permalink / raw)
To: Michal Marek, Roman Zippel; +Cc: linux-kernel, linux-kbuild, Nir Tzachar
On 04/06/2011 03:07 PM, Stephen Boyd wrote:
> Ignore the return value from wattrset since we ignore the return
> value in nconf.gui.c as well.
>
> scripts/kconfig/nconf.c: In function 'print_function_line':
> scripts/kconfig/nconf.c:376: warning: value computed is not used
> scripts/kconfig/nconf.c:380: warning: value computed is not used
> scripts/kconfig/nconf.c:387: warning: value computed is not used
> scripts/kconfig/nconf.c: In function 'show_menu':
> scripts/kconfig/nconf.c:956: warning: value computed is not used
> scripts/kconfig/nconf.c:961: warning: value computed is not used
> scripts/kconfig/nconf.c:963: warning: value computed is not used
> scripts/kconfig/nconf.c:965: warning: value computed is not used
>
> Cc: Nir Tzachar <nir.tzachar@gmail.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Ping? Nack? Ack?
> scripts/kconfig/nconf.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index db56377..488dd74 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -373,18 +373,18 @@ static void print_function_line(void)
> const int skip = 1;
>
> for (i = 0; i < function_keys_num; i++) {
> - wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
> + (void) wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
> mvwprintw(main_window, LINES-3, offset,
> "%s",
> function_keys[i].key_str);
> - wattrset(main_window, attributes[FUNCTION_TEXT]);
> + (void) wattrset(main_window, attributes[FUNCTION_TEXT]);
> offset += strlen(function_keys[i].key_str);
> mvwprintw(main_window, LINES-3,
> offset, "%s",
> function_keys[i].func);
> offset += strlen(function_keys[i].func) + skip;
> }
> - wattrset(main_window, attributes[NORMAL]);
> + (void) wattrset(main_window, attributes[NORMAL]);
> }
>
> /* help */
> @@ -953,16 +953,16 @@ static void show_menu(const char *prompt, const char *instructions,
> current_instructions = instructions;
>
> clear();
> - wattrset(main_window, attributes[NORMAL]);
> + (void) wattrset(main_window, attributes[NORMAL]);
> print_in_middle(stdscr, 1, 0, COLS,
> menu_backtitle,
> attributes[MAIN_HEADING]);
>
> - wattrset(main_window, attributes[MAIN_MENU_BOX]);
> + (void) wattrset(main_window, attributes[MAIN_MENU_BOX]);
> box(main_window, 0, 0);
> - wattrset(main_window, attributes[MAIN_MENU_HEADING]);
> + (void) wattrset(main_window, attributes[MAIN_MENU_HEADING]);
> mvwprintw(main_window, 0, 3, " %s ", prompt);
> - wattrset(main_window, attributes[NORMAL]);
> + (void) wattrset(main_window, attributes[NORMAL]);
>
> set_menu_items(curses_menu, curses_menu_items);
>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nconfig: Silence unused return values from wattrset
2011-04-18 22:38 ` Stephen Boyd
@ 2011-04-19 7:22 ` Michal Marek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2011-04-19 7:22 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Roman Zippel, linux-kernel, linux-kbuild, Nir Tzachar
On Mon, Apr 18, 2011 at 03:38:56PM -0700, Stephen Boyd wrote:
> On 04/06/2011 03:07 PM, Stephen Boyd wrote:
> > Ignore the return value from wattrset since we ignore the return
> > value in nconf.gui.c as well.
> >
> > scripts/kconfig/nconf.c: In function 'print_function_line':
> > scripts/kconfig/nconf.c:376: warning: value computed is not used
> > scripts/kconfig/nconf.c:380: warning: value computed is not used
> > scripts/kconfig/nconf.c:387: warning: value computed is not used
> > scripts/kconfig/nconf.c: In function 'show_menu':
> > scripts/kconfig/nconf.c:956: warning: value computed is not used
> > scripts/kconfig/nconf.c:961: warning: value computed is not used
> > scripts/kconfig/nconf.c:963: warning: value computed is not used
> > scripts/kconfig/nconf.c:965: warning: value computed is not used
> >
> > Cc: Nir Tzachar <nir.tzachar@gmail.com>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
>
> Ping? Nack? Ack?
Sorry, I missed this patch. I applied it do kbuild-2.6.git#kconfig now.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-19 7:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-06 22:07 [PATCH] nconfig: Silence unused return values from wattrset Stephen Boyd
2011-04-18 22:38 ` Stephen Boyd
2011-04-19 7:22 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox