From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Sam Ravnborg <sam@ravnborg.org>, Michal Marek <mmarek@suse.cz>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v3.2] kbuild: implement several W= levels
Date: Wed, 27 Apr 2011 13:21:00 -0700 [thread overview]
Message-ID: <1303935660.24299.76.camel@Joe-Laptop> (raw)
In-Reply-To: <1303935327-5154-1-git-send-email-bp@alien8.de>
On Wed, 2011-04-27 at 22:15 +0200, Borislav Petkov wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
[]
> +warning-1 += -Wold-style-definition
> +warning-1 += $(call cc-option, -Wmissing-include-dirs)
Only thing I would suggest is a comment describing why
some entries use $(call cc-option, -Wfoo) and others don't.
Something akin to:
# Use call cc-option when the minimum supported gcc version does not
# support a specific option but a later gcc version does.
next prev parent reply other threads:[~2011-04-27 20:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 21:39 [RFC PATCH] kbuild: implement several W= levels Sam Ravnborg
2011-04-21 21:58 ` Joe Perches
2011-04-21 22:56 ` Stratos Psomadakis
2011-04-21 22:06 ` Stratos Psomadakis
2011-04-22 1:28 ` Sam Ravnborg
2011-04-22 7:38 ` [RFC PATCH v2] " Sam Ravnborg
2011-04-22 8:19 ` [RFC PATCH] " Borislav Petkov
2011-04-22 10:15 ` Sam Ravnborg
2011-04-22 10:20 ` Borislav Petkov
2011-04-22 10:46 ` [PATCH v3] " Borislav Petkov
2011-04-22 11:09 ` Sam Ravnborg
2011-04-22 17:50 ` [PATCH v3.1] " Borislav Petkov
2011-04-26 19:52 ` Michal Marek
2011-04-26 20:43 ` Borislav Petkov
2011-04-27 8:22 ` Sam Ravnborg
2011-04-27 8:25 ` Sam Ravnborg
2011-04-27 11:35 ` Borislav Petkov
2011-04-27 20:15 ` [PATCH v3.2] " Borislav Petkov
2011-04-27 20:21 ` Joe Perches [this message]
2011-04-27 20:46 ` Sam Ravnborg
2011-04-27 20:46 ` Sam Ravnborg
2011-04-28 16:18 ` Michal Marek
2011-04-28 0:25 ` [PATCH v3.1] " Valdis.Kletnieks
2011-04-28 16:24 ` Michal Marek
2011-04-28 17:59 ` Valdis.Kletnieks
2011-04-29 13:31 ` [PATCH] kbuild: Allow to combine multiple " Michal Marek
2011-04-29 17:43 ` Sam Ravnborg
2011-04-29 18:13 ` Arnaud Lacombe
2011-04-29 18:27 ` Valdis.Kletnieks
2011-04-29 18:29 ` Valdis.Kletnieks
2011-05-02 15:38 ` Michal Marek
2011-05-02 15:53 ` Arnaud Lacombe
2011-05-02 16:05 ` Michal Marek
2011-05-02 16:17 ` Arnaud Lacombe
2011-05-02 16:16 ` Américo Wang
2011-05-02 17:07 ` Sam Ravnborg
2011-05-02 17:34 ` Arnaud Lacombe
2011-05-02 18:03 ` boris
2011-05-02 18:45 ` Arnaud Lacombe
2011-05-02 18:51 ` boris
2011-05-02 20:35 ` Michal Marek
2011-04-27 8:27 ` [PATCH v3] kbuild: implement several " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303935660.24299.76.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=davej@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox