From: David Woodhouse <dwmw2@infradead.org>
To: Michal Marek <mmarek@suse.cz>
Cc: Arun Sharma <asharma@fb.com>,
linux-kbuild@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add $KERNELRELEASE to firmware install path
Date: Fri, 06 May 2011 11:18:32 +0100 [thread overview]
Message-ID: <1304677113.20656.2.camel@i7.infradead.org> (raw)
In-Reply-To: <4DC3CA39.30806@suse.cz>
On Fri, 2011-05-06 at 12:15 +0200, Michal Marek wrote:
>
> On 5.5.2011 19:39, Arun Sharma wrote:
> > Useful in the presence of multiple kernels with different
> > firmware versions.
>
> The changelog should also include the udev version that is able to find
> the firmware there (v127, August 2008). FWIW, SUSE has been using this
> patch since about that time, but we forgot to push this :-|. Anyway
No, this is fundamentally broken. Do not do it.
The firmware lives in /lib/firmware, not in /lib/firmware/$KERNELVERSION
There is *no* reason to move it there. If a given firmware file changes
in an incompatible way, it needs to have had a new filename *anyway*
(think of it like a new soname on a shared library).
And we shouldn't be updating the legacy firmware images in the kernel
*anyway*; nobody should be using those any more. They were *purely* for
backward compatibility. Everyone should be shipping the
linux-firmware.git images instead.
--
dwmw2
next prev parent reply other threads:[~2011-05-06 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 17:39 [PATCH] Add $KERNELRELEASE to firmware install path Arun Sharma
2011-05-06 10:15 ` Michal Marek
2011-05-06 10:18 ` David Woodhouse [this message]
2011-05-06 18:44 ` Arun Sharma
2011-05-06 19:02 ` David Woodhouse
2011-05-06 22:37 ` Arun Sharma
2011-05-16 14:21 ` Michal Marek
2011-05-17 11:23 ` David Woodhouse
2011-05-17 11:37 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304677113.20656.2.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=asharma@fb.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox