Re: [RFCv5] Kbuild: factor parser rules

Arnaud Lacombe
2011-06-08T16:11:10Z

Hi,

On Wed, Jun 8, 2011 at 11:38 AM, Michal Marek <mmarek@suse.cz> wrote:
> On Wed, Jun 08, 2011 at 01:03:28AM -0400, Arnaud Lacombe wrote:
>> Hi Michal,
>>
>> Here is some update concerning the parser generation merge. I do not repost the
>> whole serie as it may be overkill. You can find the latest branch at:
>>
>> git://github.com/lacombar/linux-2.6.git kbuild-implicit-parser-rule
>>
>> So let't get it done the safe way...
>>
>> Changes since v4:
>> [...]
>
>
> Hi, I found now what my problem with genksyms was. I use O= and you
> removed the -I$(src) for the lexer (which is a generated file, but needs
> genksyms.h from the source directory). With the following patch,
> everything should work again (test builds still running, but they built
> genksyms already):
>
yes, I spotted that yesterday, this is fixed in v5.

- Arnaud

> diff --git a/scripts/genksyms/Makefile b/scripts/genksyms/Makefile
> index 0b883e3..ee1071f 100644
> --- a/scripts/genksyms/Makefile
> +++ b/scripts/genksyms/Makefile
> @@ -6,6 +6,7 @@ genksyms-objs   := genksyms.o parse.tab.o lex.lex.o
>
>  # -I needed for generated C source (shipped source)
>  HOSTCFLAGS_parse.tab.o := -Wno-uninitialized -I$(src)
> +HOSTCFLAGS_lex.lex.o := -I$(src)
>
>  $(obj)/parse.tab.o: $(obj)/parse.tab.c $(obj)/parse.tab.h
>
> Michal
>