public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: rdunlap@xenotime.net
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 2/3] sort SECTION 2 output of scripts/export_report.pl
Date: Mon, 23 May 2011 12:44:56 -0600	[thread overview]
Message-ID: <1306176297-6964-3-git-send-email-jim.cromie@gmail.com> (raw)
In-Reply-To: <1306176297-6964-1-git-send-email-jim.cromie@gmail.com>

Sort SECTION 2 modules by name.  Within those module listings, sort
the symbol providers by name, and remove the count, as it is
misleading; its the kernel-wide count of uses of that symbol, not the
count pertaining to the module being outlined.  (this can be seen by
grepping the output for a single symbol).  The count is still used to
sort the symbols.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 scripts/export_report.pl |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/scripts/export_report.pl b/scripts/export_report.pl
index f97899c..48398a1 100644
--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -25,11 +25,12 @@ sub alphabetically {
 sub print_depends_on {
 	my ($href) = @_;
 	print "\n";
-	while (my ($mod, $list) = each %$href) {
+	for my $mod (sort keys %$href) {
+		my $list = $href->{$mod};
 		print "\t$mod:\n";
 		foreach my $sym (sort numerically @{$list}) {
 			my ($symbol, $no) = split /\s+/, $sym;
-			printf("\t\t%-25s\t%-25d\n", $symbol, $no);
+			printf("\t\t%-25s\n", $symbol);
 		}
 		print "\n";
 	}
@@ -166,7 +167,8 @@ modules. Each module lists the modules, and the symbols from that module that
 it uses.  Each listed symbol reports the number of modules using it\n");
 
 print "~"x80 , "\n";
-while (my ($thismod, $list) = each %MODULE) {
+for my $thismod (sort keys %MODULE) {
+	my $list = $MODULE{$thismod};
 	my %depends;
 	$thismod =~ s/\.mod\.c/.ko/;
 	print "\t\t\t$thismod\n";
-- 
1.7.4.4


  parent reply	other threads:[~2011-05-23 18:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21  8:21 [PATCH 0/3] fixes, improvements on scripts/export_report.pl Jim Cromie
2011-05-21  8:21 ` [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline Jim Cromie
2011-05-23  2:16   ` Randy Dunlap
2011-05-21  8:21 ` [PATCH 2/3] sort SECTION 2 output of scripts/export_report.pl Jim Cromie
2011-05-21  8:21 ` [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr Jim Cromie
2011-05-23 15:21   ` Randy Dunlap
2011-05-23 18:44   ` [PATCH 0/3 rev2] fix scripts/export_report.pl Jim Cromie
2011-05-23 18:44     ` [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline Jim Cromie
2011-05-23 18:44     ` Jim Cromie [this message]
2011-05-23 18:44     ` [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr Jim Cromie
2011-05-24 14:10     ` [PATCH 0/3 rev2] fix scripts/export_report.pl Michal Marek
2011-05-24 17:53       ` Jim Cromie
2011-05-25 12:15         ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306176297-6964-3-git-send-email-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox