From: Hiromu Yakura <hiromu1996@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
zippel@linux-m68k.org
Subject: Re: [PATCH] Kconfig: add warning about permission of config file
Date: Tue, 24 May 2011 23:26:32 +0900 [thread overview]
Message-ID: <1306247192.7501.25.camel@hiromu-MacBook> (raw)
In-Reply-To: <4DDBB150.2090602@suse.cz>
Hello,
On Fri, May 24, 2011 at 22:23, Michal Marek <mmarek@suse.cz> wrote:
> Arnaud's point is that your patch should not be necessary at all,
> because kconfig already checks the return value of the fopen() call in
> conf_write() and prints the above message if it fails. So do you have a
> testcase where make <...>config without your patch returns without
> error, but the configuration is not written?
Sorry for misunderstanding.
Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...)
raise error.
And only xconfig and gconfig don't write the configuration without
error.
However, make *config using 'conf' hasn't function of 'Save as'.
In other words, if you don't set the write permission to the directory,
you would lose changes of the configuration.
I think that it is necessary to check permission at all so that kconfig
warn of the possibility of losing changes.
Thanks
next prev parent reply other threads:[~2011-05-24 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1306167401.18840.8.camel@hiromu-MacBook>
[not found] ` <BANLkTikhFdd_PRzCg3w9HD1TO=cmdmm6_A@mail.gmail.com>
2011-05-24 13:06 ` [PATCH] Kconfig: add warning about permission of config file Hiromu Yakura
2011-05-24 13:23 ` Michal Marek
2011-05-24 14:26 ` Hiromu Yakura [this message]
2011-05-24 15:01 ` Michal Marek
2011-05-24 15:50 ` Arnaud Lacombe
2011-05-24 16:49 ` Sam Ravnborg
2011-05-24 17:38 ` Hiromu Yakura
2011-05-24 17:59 ` Arnaud Lacombe
2011-05-24 20:46 ` Hiromu Yakura
2011-05-24 21:49 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306247192.7501.25.camel@hiromu-MacBook \
--to=hiromu1996@gmail.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox