From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:37163 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126Ab1EXO0h (ORCPT ); Tue, 24 May 2011 10:26:37 -0400 Subject: Re: [PATCH] Kconfig: add warning about permission of config file From: Hiromu Yakura In-Reply-To: <4DDBB150.2090602@suse.cz> References: <1306167401.18840.8.camel@hiromu-MacBook> <1306242400.7501.10.camel@hiromu-MacBook> <4DDBB150.2090602@suse.cz> Content-Type: text/plain; charset="UTF-8" Date: Tue, 24 May 2011 23:26:32 +0900 Message-ID: <1306247192.7501.25.camel@hiromu-MacBook> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Michal Marek Cc: Arnaud Lacombe , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, zippel@linux-m68k.org Hello, On Fri, May 24, 2011 at 22:23, Michal Marek wrote: > Arnaud's point is that your patch should not be necessary at all, > because kconfig already checks the return value of the fopen() call in > conf_write() and prints the above message if it fails. So do you have a > testcase where make <...>config without your patch returns without > error, but the configuration is not written? Sorry for misunderstanding. Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...) raise error. And only xconfig and gconfig don't write the configuration without error. However, make *config using 'conf' hasn't function of 'Save as'. In other words, if you don't set the write permission to the directory, you would lose changes of the configuration. I think that it is necessary to check permission at all so that kconfig warn of the possibility of losing changes. Thanks