From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e35.co.us.ibm.com ([32.97.110.153]:36980 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933004Ab1IBBka (ORCPT ); Thu, 1 Sep 2011 21:40:30 -0400 Subject: Re: linux-next: Tree for Aug 22 (evm) From: Mimi Zohar In-Reply-To: References: <20110822145304.980529cb921e5f1321c622da@canb.auug.org.au> <20110822125355.bb01d76b.rdunlap@xenotime.net> <20110822174958.73dd96c7.rdunlap@xenotime.net> <1314065358.3225.44.camel@localhost.localdomain> <20110823164035.ca28fdc6.rdunlap@xenotime.net> <1314362342.3224.19.camel@localhost.localdomain> <20110826100011.9213d872.rdunlap@xenotime.net> Content-Type: text/plain; charset="UTF-8" Date: Thu, 01 Sep 2011 21:40:25 -0400 Message-ID: <1314927625.3058.53.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Arnaud Lacombe Cc: Randy Dunlap , Stephen Rothwell , Mimi Zohar , linux-next@vger.kernel.org, LKML , linux-kbuild@vger.kernel.org On Thu, 2011-09-01 at 20:32 -0400, Arnaud Lacombe wrote: > Hi, > > On Sat, Aug 27, 2011 at 2:06 AM, Arnaud Lacombe wrote: > > Hi, > > > > On Fri, Aug 26, 2011 at 1:00 PM, Randy Dunlap wrote: > >> On Fri, 26 Aug 2011 08:39:02 -0400 Mimi Zohar wrote: > >> > >>> On Tue, 2011-08-23 at 22:10 -0400, Arnaud Lacombe wrote: > >>> > Hi, > >>> > > >>> > On Tue, Aug 23, 2011 at 7:40 PM, Randy Dunlap wrote: > >>> > > I think that you are going to need to do something like Arnaud suggested > >>> > > and use "depends on TCG_TPM=y" instead of just "depends on TCG_TPM", > >>> > > unless you can convince someone that this is a kconfig bug. > >>> > > > >>> > dammit... I guess there is... > >>> > > >>> > If you consider the following Kconfig: > >>> > > >>> > config MOD > >>> > bool > >>> > default y > >>> > option modules > >>> > > >>> > config EXPERIMENTAL > >>> > bool > >>> > default y > >>> > > >>> > menuconfig A > >>> > tristate "A" > >>> > depends on EXPERIMENTAL > >>> > > >>> > config B > >>> > bool "B" > >>> > > >>> > config B0 > >>> > bool > >>> > > >>> > config C > >>> > tristate "C" > >>> > depends on B > >>> > > >>> > config C0 > >>> > tristate > >>> > > >>> > config D > >>> > boolean "D" > >>> > depends on A && B > >>> > select C > >>> > select C0 > >>> > > >>> > config E > >>> > tristate "E" > >>> > > >>> > config F > >>> > tristate "F" > >>> > select E > >>> > > >>> > B (KEYS) allows to set C (TRUSTED_KEYS). Also, B (KEYS) and A > >>> > (TCG_TPM) allows to set D (EVM), which will select (C). Now, > >>> > menuconfig highlight the problem very well. Proceeding as following > >>> > A=m, B=y, C=m, E=y, F=y, we ends up having: > >>> > > >>> > A ---> > >>> > [*] B > >>> > {M} C > >>> > [*] D > >>> > -*- E > >>> > <*> F > >>> > > >>> > which translate in the following config: > >>> > > >>> > CONFIG_MOD=y > >>> > CONFIG_EXPERIMENTAL=y > >>> > CONFIG_A=m > >>> > CONFIG_B=y > >>> > CONFIG_C=m > >>> > CONFIG_C0=m > >>> > CONFIG_D=y > >>> > CONFIG_E=y > >>> > CONFIG_F=y > >>> > > >>> > I would have expected CONFIG_C and CONFIG_C0 to be 'y', just as 'E'. > >>> > If you remove D's dependency on 'A', everything works as expected. So > >>> > it would seem direct dependency state influence the state of reverse > >>> > dependencies... > >>> > > >>> > Will have a look... > >>> > > >>> > - Arnaud > >>> > >>> Thanks for looking into this! Instead of changing 'TCG_TPM' to > >>> 'TCG_TPM=y', the dependency should be on 'TRUSTED_KEYS=y'. Then when > >>> I've refactored ENCRYPTED_KEYS, removing the ENCRYPTED_KEYS dependency > >>> on TRUSTED_KEYS, the EVM dependency would be '(TRUSTED_KEYS=y || > >>> TRUSTED_KEYS=n)'. Do you want a temporary fix for now? > >> > >> Yes, linux-next (randconfig) builds are still failing, so we need something > >> to prevent that. > >> > > you may want to try: > > > > git://github.com/lacombar/linux-2.6.git master/kconfig/expr-woes > > > ping ? > > - Arnaud I assume you want me to test using expr-woes, but I'm not how. Could you help me here a bit. (Over the weekend I removed encrypted keys dependency on TCG_TPM.) thanks, Mimi > > only the last commit is relevant to the problem, but depend on one > > another to get . The rest aims at tidying the expr stuff. > > I'm looking for regression it may have introduced. > > > > Thanks, > > - Arnaud > > > > ps: I'll most likely be AFK until sunday evening (to be conservative). > > > >> thanks, > >> --- > >> ~Randy > >> *** Remember to use Documentation/SubmitChecklist when testing your code *** > >> > > >