From: John Stultz <john.stultz@linaro.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>,
gthelen@google.com, Dmitry Fink <Dmitry.Fink@palm.com>,
Eric B Munson <ebmunson@us.ibm.com>,
Bruce Ashfield <Bruce.Ashfield@windriver.com>,
Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org,
Richard Tartler <Reinhard.Tartler@informatik.uni-erlangen.de>
Subject: Re: [PATCH 1/2] merge_config.sh: use signal names compatible with dash and bash
Date: Mon, 21 Nov 2011 12:05:37 -0800 [thread overview]
Message-ID: <1321905937.6445.3.camel@work-vm> (raw)
In-Reply-To: <591b0f764fd9eb0bc7873ef775052cb038484ae7.1321904550.git.dvhart@linux.intel.com>
On Mon, 2011-11-21 at 11:42 -0800, Darren Hart wrote:
> The SIGHUP SIGINT and SIGTERM names caused failures when running
> merge_config.sh with the dash shell. Dropping the "SIG" component
> makes the script work in both bash and dash.
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Acked-by: John Stultz <john.stultz@linaro.org>
> ---
> scripts/kconfig/merge_config.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
> index 890276b..b91015d 100755
> --- a/scripts/kconfig/merge_config.sh
> +++ b/scripts/kconfig/merge_config.sh
> @@ -24,7 +24,7 @@ clean_up() {
> rm -f $TMP_FILE
> exit
> }
> -trap clean_up SIGHUP SIGINT SIGTERM
> +trap clean_up HUP INT TERM
>
> usage() {
> echo "Usage: $0 [OPTIONS] [CONFIG [...]]"
prev parent reply other threads:[~2011-11-21 20:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 21:58 [PATCH] kconfig: Add merge_config.sh script john stultz
2011-11-17 22:44 ` Arnaud Lacombe
2011-11-17 22:54 ` john stultz
2011-11-19 6:24 ` Arnaud Lacombe
2011-11-21 18:22 ` Darren Hart
2011-11-21 23:29 ` john stultz
2011-11-21 23:41 ` john stultz
2011-11-19 6:51 ` Arnaud Lacombe
2011-11-21 18:32 ` Darren Hart
2011-11-21 22:06 ` John Stultz
2011-11-21 22:48 ` john stultz
2011-11-21 22:55 ` john stultz
2011-11-22 6:25 ` Arnaud Lacombe
2011-11-20 12:56 ` Michal Marek
2011-11-20 18:05 ` Arnaud Lacombe
2011-11-21 18:34 ` Darren Hart
2011-11-21 19:42 ` [PATCH 1/2] merge_config.sh: use signal names compatible with dash and bash Darren Hart
2011-11-21 19:42 ` [PATCH 2/2] merge_config.sh: whitespace cleanup Darren Hart
2011-11-21 20:14 ` John Stultz
2011-11-21 20:05 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321905937.6445.3.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=Bruce.Ashfield@windriver.com \
--cc=Dmitry.Fink@palm.com \
--cc=Reinhard.Tartler@informatik.uni-erlangen.de \
--cc=akpm@linux-foundation.org \
--cc=dvhart@linux.intel.com \
--cc=ebmunson@us.ibm.com \
--cc=gthelen@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).