* [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD_OUTPUT
@ 2013-02-25 3:05 Bin Wang
2013-03-14 1:30 ` Bin Wang
0 siblings, 1 reply; 3+ messages in thread
From: Bin Wang @ 2013-02-25 3:05 UTC (permalink / raw)
To: mmarek, linux-kbuild, linux-kernel; +Cc: Bin Wang
KBUILD_OUTPUT is always empty here, so it is useless to test it. But
while use O=.., objtree and srctree will be different. I compare them
instead.
Signed-off-by: Bin Wang <wbin00@gmail.com>
---
scripts/package/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 87bf080..d7b3285 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -36,7 +36,7 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile
$(CONFIG_SHELL) $(MKSPEC) > $@
rpm-pkg rpm: $(objtree)/kernel.spec FORCE
- @if test -n "$(KBUILD_OUTPUT)"; then \
+ @if test "$(objtree)" != "$(srctree)"; then \
echo "Building source + binary RPM is not possible outside the"; \
echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \
echo "binrpm-pkg target instead."; \
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD_OUTPUT
2013-02-25 3:05 [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD_OUTPUT Bin Wang
@ 2013-03-14 1:30 ` Bin Wang
2013-04-08 11:05 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Bin Wang @ 2013-03-14 1:30 UTC (permalink / raw)
To: mmarek, linux-kbuild, linux-kernel
Hi, Michal
Is there any comments on this?
2013/2/25 Bin Wang <wbin00@gmail.com>:
> KBUILD_OUTPUT is always empty here, so it is useless to test it. But
> while use O=.., objtree and srctree will be different. I compare them
> instead.
>
> Signed-off-by: Bin Wang <wbin00@gmail.com>
> ---
> scripts/package/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index 87bf080..d7b3285 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile
> @@ -36,7 +36,7 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile
> $(CONFIG_SHELL) $(MKSPEC) > $@
>
> rpm-pkg rpm: $(objtree)/kernel.spec FORCE
> - @if test -n "$(KBUILD_OUTPUT)"; then \
> + @if test "$(objtree)" != "$(srctree)"; then \
> echo "Building source + binary RPM is not possible outside the"; \
> echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \
> echo "binrpm-pkg target instead."; \
> --
> 1.8.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD_OUTPUT
2013-03-14 1:30 ` Bin Wang
@ 2013-04-08 11:05 ` Michal Marek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2013-04-08 11:05 UTC (permalink / raw)
To: Bin Wang; +Cc: linux-kbuild, linux-kernel
On Thu, Mar 14, 2013 at 09:30:32AM +0800, Bin Wang wrote:
> Hi, Michal
>
> Is there any comments on this?
Sorry, I missed this one. I applied it to kbuild.git#misc now.
Michal
>
> 2013/2/25 Bin Wang <wbin00@gmail.com>:
> > KBUILD_OUTPUT is always empty here, so it is useless to test it. But
> > while use O=.., objtree and srctree will be different. I compare them
> > instead.
> >
> > Signed-off-by: Bin Wang <wbin00@gmail.com>
> > ---
> > scripts/package/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> > index 87bf080..d7b3285 100644
> > --- a/scripts/package/Makefile
> > +++ b/scripts/package/Makefile
> > @@ -36,7 +36,7 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile
> > $(CONFIG_SHELL) $(MKSPEC) > $@
> >
> > rpm-pkg rpm: $(objtree)/kernel.spec FORCE
> > - @if test -n "$(KBUILD_OUTPUT)"; then \
> > + @if test "$(objtree)" != "$(srctree)"; then \
> > echo "Building source + binary RPM is not possible outside the"; \
> > echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \
> > echo "binrpm-pkg target instead."; \
> > --
> > 1.8.1.4
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-08 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-25 3:05 [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD_OUTPUT Bin Wang
2013-03-14 1:30 ` Bin Wang
2013-04-08 11:05 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox