From: Jean Delvare <jdelvare@suse.de>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH 1/3] Documentation/kconfig: more concise and straightforward search explanation
Date: Tue, 16 Jul 2013 16:14:25 +0200 [thread overview]
Message-ID: <1373984065.4513.5.camel@chaos.site> (raw)
In-Reply-To: <1373738905-23396-2-git-send-email-yann.morin.1998@free.fr>
Le Saturday 13 July 2013 à 20:08 +0200, Yann E. MORIN a écrit :
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Re-phrase the explanations on the sorting of search results, in a more
> concise and complete way.
>
> Drop reference to the user's locale when sorting alphabetically, since
> this is implicit.
>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Jean Delvare <jdelvare@suse.de>
> ---
> Documentation/kbuild/kconfig.txt | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/kbuild/kconfig.txt b/Documentation/kbuild/kconfig.txt
> index e9f9e76..6edf37d 100644
> --- a/Documentation/kbuild/kconfig.txt
> +++ b/Documentation/kbuild/kconfig.txt
> @@ -175,11 +175,9 @@ Searching in menuconfig:
> /^hotplug
>
> When searching, symbols are sorted thus:
> - - exact match first: an exact match is when the search matches
> - the complete symbol name;
> - - alphabetical order: when two symbols do not match exactly,
> - they are sorted in alphabetical order (in the user's current
> - locale).
> + - first, exact matches, sorted alphabetically (an exact match │18:03 -!- - keep a notice in the topic and perhaps as an on-join message).
> + is when the search matches the complete symbol name); │18:03 -!- -
> + - then, other matches, sorted alphabetically.
> For example: ^ATH.K matches:
> ATH5K ATH9K ATH5K_AHB ATH5K_DEBUG [...] ATH6KL ATH6KL_DEBUG
> [...] ATH9K_AHB ATH9K_BTCOEX_SUPPORT ATH9K_COMMON [...]
After fixing the copy-and-paste mistake, this looks good to me.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
Suse L3
next prev parent reply other threads:[~2013-07-16 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 18:08 [PATCH 0/3] Misc cleanups in kconfig for symbol-search Yann E. MORIN
2013-07-13 18:08 ` [PATCH 1/3] Documentation/kconfig: more concise and straightforward search explanation Yann E. MORIN
2013-07-13 18:14 ` Yann E. MORIN
2013-07-16 14:14 ` Jean Delvare [this message]
2013-07-13 18:08 ` [PATCH 2/3] kconfig: avoid multiple calls to strlen Yann E. MORIN
2013-07-16 14:21 ` Jean Delvare
2013-07-13 18:08 ` [PATCH 3/3] kconfig: cleanup symbol-search code Yann E. MORIN
2013-07-16 14:33 ` Jean Delvare
2013-07-16 14:42 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373984065.4513.5.camel@chaos.site \
--to=jdelvare@suse.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox