From: Jean Delvare <jdelvare@suse.de>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH 3/3] kconfig: cleanup symbol-search code
Date: Tue, 16 Jul 2013 16:33:47 +0200 [thread overview]
Message-ID: <1373985227.4513.12.camel@chaos.site> (raw)
In-Reply-To: <1373738905-23396-4-git-send-email-yann.morin.1998@free.fr>
Le Saturday 13 July 2013 à 20:08 +0200, Yann E. MORIN a écrit :
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> - no need for a double-indirection for the temporary sym_match_arr array
> - the temporary sym_match_arr array is not NULL terminated, so no need
> to allocate n+1 elements
> - two minor style fixes
> - grammar fix in comment
>
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Jean Delvare <jdelvare@suse.de>
> ---
> scripts/kconfig/symbol.c | 39 +++++++++++++++------------------------
> 1 file changed, 15 insertions(+), 24 deletions(-)
> (...)
You mixed style cleanups with actual code changes, which is usually
avoided. Michal may ask you to split these changes into two separate
patches.
Still, I'm happy with all the changes:
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
Suse L3
next prev parent reply other threads:[~2013-07-16 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 18:08 [PATCH 0/3] Misc cleanups in kconfig for symbol-search Yann E. MORIN
2013-07-13 18:08 ` [PATCH 1/3] Documentation/kconfig: more concise and straightforward search explanation Yann E. MORIN
2013-07-13 18:14 ` Yann E. MORIN
2013-07-16 14:14 ` Jean Delvare
2013-07-13 18:08 ` [PATCH 2/3] kconfig: avoid multiple calls to strlen Yann E. MORIN
2013-07-16 14:21 ` Jean Delvare
2013-07-13 18:08 ` [PATCH 3/3] kconfig: cleanup symbol-search code Yann E. MORIN
2013-07-16 14:33 ` Jean Delvare [this message]
2013-07-16 14:42 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373985227.4513.12.camel@chaos.site \
--to=jdelvare@suse.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox