From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:37967 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754734Ab3GPOeF (ORCPT ); Tue, 16 Jul 2013 10:34:05 -0400 Subject: Re: [PATCH 3/3] kconfig: cleanup symbol-search code From: Jean Delvare In-Reply-To: <1373738905-23396-4-git-send-email-yann.morin.1998@free.fr> References: <1373738905-23396-1-git-send-email-yann.morin.1998@free.fr> <1373738905-23396-4-git-send-email-yann.morin.1998@free.fr> Content-Type: text/plain; charset="UTF-8" Date: Tue, 16 Jul 2013 16:33:47 +0200 Message-ID: <1373985227.4513.12.camel@chaos.site> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: "Yann E. MORIN" Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek Le Saturday 13 July 2013 à 20:08 +0200, Yann E. MORIN a écrit : > From: "Yann E. MORIN" > > - no need for a double-indirection for the temporary sym_match_arr array > - the temporary sym_match_arr array is not NULL terminated, so no need > to allocate n+1 elements > - two minor style fixes > - grammar fix in comment > > Reported-by: Jean Delvare > Signed-off-by: "Yann E. MORIN" > Cc: Jean Delvare > --- > scripts/kconfig/symbol.c | 39 +++++++++++++++------------------------ > 1 file changed, 15 insertions(+), 24 deletions(-) > (...) You mixed style cleanups with actual code changes, which is usually avoided. Michal may ask you to split these changes into two separate patches. Still, I'm happy with all the changes: Reviewed-by: Jean Delvare -- Jean Delvare Suse L3