From: Brian Norris <computersforpeace@gmail.com>
To: linux-kbuild@vger.kernel.org
Cc: Brian Norris <computersforpeace@gmail.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
Martin Walch <walch.martin@web.de>
Subject: [PATCH 2/2] kconfig: nconfig: fix multi-byte UTF handling
Date: Wed, 4 Jun 2014 00:52:31 -0700 [thread overview]
Message-ID: <1401868351-24014-3-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1401868351-24014-1-git-send-email-computersforpeace@gmail.com>
Currently, Kconfig descriptions that use multi-byte UTF-8 characters
(such as MTD_NAND_CAFE) will have their menu entries dropped from the
'make nconfig' ncurses menu, and all subsequent entries in the same
window will be omitted. This seems to be due to the ncurses 'menu'
library, which does not traditionally handle UTF-8 >8-bit characters
properly.
The ncursesw library ('w' is for "wide") is written to handle these
UTF-8 characters, and is practically a drop-in replacement at the source
level. Use it by default, if available.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=43067
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org
Cc: Martin Walch <walch.martin@web.de>
---
scripts/kconfig/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 844bc9da08da..0171566cc12a 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -220,7 +220,8 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
HOSTLOADLIBES_nconf = $(shell \
- pkg-config --libs menu panel ncurses 2>/dev/null \
+ pkg-config --libs menuw panelw ncursesw 2>/dev/null \
+ || pkg-config --libs menu panel ncurses 2>/dev/null \
|| echo "-lmenu -lpanel -lncurses" )
$(obj)/qconf.o: $(obj)/.tmp_qtcheck
--
1.7.9.5
next prev parent reply other threads:[~2014-06-04 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 7:52 [PATCH 0/2] kconfig: fix multi-byte UTF handling in nconfig Brian Norris
2014-06-04 7:52 ` [PATCH 1/2] kconfig: lxdialog: fix spelling Brian Norris
2014-06-04 7:52 ` Brian Norris [this message]
2014-06-06 13:18 ` [PATCH 2/2] kconfig: nconfig: fix multi-byte UTF handling Sam Ravnborg
2014-06-05 1:53 ` [PATCH 0/2] kconfig: fix multi-byte UTF handling in nconfig Martin Walch
2014-06-06 13:16 ` Sam Ravnborg
2014-06-06 13:17 ` Sam Ravnborg
2014-07-10 8:52 ` Brian Norris
2014-08-20 16:40 ` Brian Norris
2014-08-22 11:02 ` Michal Marek
2014-08-24 5:17 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401868351-24014-3-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=walch.martin@web.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox