From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
David Herrmann <dh.herrmann@googlemail.com>,
Jiri Kosina <jkosina@suse.cz>, Sam Ravnborg <sam@ravnborg.org>,
David Herrmann <dh.herrmann@gmail.com>
Subject: [PATCH 6/6] samples: use uapiprogs support for uhid
Date: Sun, 13 Jul 2014 20:42:54 +0200 [thread overview]
Message-ID: <1405276974-17323-6-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <1405276974-17323-1-git-send-email-sam@ravnborg.org>
uhid was not included in the regular builds as it was not wired
up in samples/Makefile.
Fix build on sparc32 by defining __USE_GNU to get visibility to O_CLOEXEC.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: David Herrmann <dh.herrmann@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>
---
samples/Makefile | 1 +
samples/uhid/Makefile | 11 +----------
samples/uhid/uhid-example.c | 5 ++++-
3 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/samples/Makefile b/samples/Makefile
index 8fc6c45..29a09bd 100644
--- a/samples/Makefile
+++ b/samples/Makefile
@@ -13,3 +13,4 @@ obj-$(CONFIG_SAMPLES) += kdb/
# user space programs
subdir-$(CONFIG_SAMPLES) += seccomp
subdir-$(CONFIG_SAMPLES) += hidraw
+subdir-$(CONFIG_SAMPLES) += uhid
diff --git a/samples/uhid/Makefile b/samples/uhid/Makefile
index c95a696..75ff2bb 100644
--- a/samples/uhid/Makefile
+++ b/samples/uhid/Makefile
@@ -1,10 +1 @@
-# kbuild trick to avoid linker error. Can be omitted if a module is built.
-obj- := dummy.o
-
-# List of programs to build
-hostprogs-y := uhid-example
-
-# Tell kbuild to always build the programs
-always := $(hostprogs-y)
-
-HOSTCFLAGS_uhid-example.o += -I$(objtree)/usr/include
+uapiprogs-y := uhid-example
diff --git a/samples/uhid/uhid-example.c b/samples/uhid/uhid-example.c
index f25a5ef..e4379c8 100644
--- a/samples/uhid/uhid-example.c
+++ b/samples/uhid/uhid-example.c
@@ -37,7 +37,6 @@
*/
#include <errno.h>
-#include <fcntl.h>
#include <poll.h>
#include <stdbool.h>
#include <stdio.h>
@@ -45,6 +44,10 @@
#include <string.h>
#include <termios.h>
#include <unistd.h>
+
+#define __USE_GNU
+#include <fcntl.h>
+
#include <linux/uhid.h>
/*
--
1.9.3
next prev parent reply other threads:[~2014-07-13 18:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 18:36 [PATCH v2 0/6] kbuild: use target compiler for user binaries in samples/ Sam Ravnborg
2014-07-13 18:42 ` [PATCH 1/6] kbuild: add support for building userspace api programs Sam Ravnborg
2014-07-13 18:42 ` [PATCH 2/6] samples: refactor Makefile Sam Ravnborg
2014-07-13 19:25 ` Randy Dunlap
2014-07-13 19:52 ` Sam Ravnborg
2014-07-13 20:13 ` Randy Dunlap
2014-07-14 0:26 ` Stephen Rothwell
2014-07-13 18:42 ` [PATCH 3/6] samples: use uapiprogs support for seccomp Sam Ravnborg
2014-07-16 9:43 ` Masahiro Yamada
2014-07-16 10:31 ` Sam Ravnborg
2014-07-17 3:40 ` Masahiro Yamada
2014-07-13 18:42 ` [PATCH 4/6] samples: use uapiprogs support for hidraw Sam Ravnborg
2014-07-13 18:42 ` [PATCH 5/6] samples: fix warnings in uhid-example Sam Ravnborg
2014-07-13 18:42 ` Sam Ravnborg [this message]
2014-07-13 19:23 ` [PATCH 1/6] kbuild: add support for building userspace api programs Randy Dunlap
2014-07-13 19:53 ` Sam Ravnborg
2014-07-14 0:29 ` [PATCH v2 0/6] kbuild: use target compiler for user binaries in samples/ Stephen Rothwell
2014-07-14 0:33 ` Stephen Rothwell
2014-07-17 15:22 ` Michal Marek
2014-08-21 13:46 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405276974-17323-6-git-send-email-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dh.herrmann@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=jkosina@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sfr@canb.auug.org.au \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox