Re: [PATCH 2/2] kconfig: allow use of relations other than (in)equality

Jan Beulich
2014-11-04T13:21:00Z

>>> On 04.11.14 at 14:14, <pebolle@tiscali.nl> wrote:
> On Tue, 2014-11-04 at 09:06 +0000, Jan Beulich wrote:
>> Question: Should "<>" and/or "==" then perhaps also be permitted?
>
> You mean as aliases for "!=" and "="?

Yes.

>> + if (k1 == k_string || k2 == k_string)
>> + res = strcmp(str1, str2);
>> + else if (k1 == k_invalid || k2 == k_invalid) {
>> + if (e->type != E_EQUAL && e->type != E_UNEQUAL) {
>> + printf("Cannot compare \"%s\" and \"%s\"\n", str1, str2);
>> +printf("(%s -> %d, %s -> %d)\n", sym_type_name(e->left.sym->type), k1,
> sym_type_name(e->right.sym->type), k2);//temp
>
> Leftover from development?

Argh - yes, definitely; I even have a note in the patch that these
should get dropped, but I managed to ignore that note.

Jan