Re: [PATCH 2/2] kconfig: allow use of relations other than (in)equality

Paul Bolle
2014-11-04T13:28:17Z

On Tue, 2014-11-04 at 13:20 +0000, Jan Beulich wrote:
> >> + if (k1 == k_string || k2 == k_string)
> >> + res = strcmp(str1, str2);
> >> + else if (k1 == k_invalid || k2 == k_invalid) {
> >> + if (e->type != E_EQUAL && e->type != E_UNEQUAL) {
> >> + printf("Cannot compare \"%s\" and \"%s\"\n", str1, str2);
> >> +printf("(%s -> %d, %s -> %d)\n", sym_type_name(e->left.sym->type), k1,
> > sym_type_name(e->right.sym->type), k2);//temp
> >
> > Leftover from development?
>
> Argh - yes, definitely; I even have a note in the patch that these
> should get dropped, but I managed to ignore that note.

If all you have to change is drop those three lines, I'll play with this
patch anyway, as I finally maltreated it enough to apply on top of my
local changes.

Paul Bolle