public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Sedat Dilek <sedat.dilek@gmail.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	maximilian attems <max@stro.at>, Thorsten Glaser <tg@debian.org>,
	Alexander Wirt <formorer@debian.org>,
	Michal Marek <mmarek@suse.cz>,
	linux-kbuild@vger.kernel.org
Subject: [RFC] builddeb: Try to determine distribution
Date: Fri,  2 Jan 2015 21:14:29 +0100	[thread overview]
Message-ID: <1420229669-5550-1-git-send-email-sedat.dilek@gmail.com> (raw)

This is based on ideas of me and Ben.
Thanks goes to Thorsten and Alexander for the vital help in 2012.

Like in my initial patch [1] lsb_release is used to determine
the short codename as distribution name for debian/changelog.

Ben gave some helpful and detailed information in [2].
There he also suggested to have an option to explicitly set the
distribution (see $KDEB_CHANGELOG_DIST variable).

I have hardcoded the script-name when the default distribution
is used. This is a bit ugly.

This patch is based on the snippet of Ben in [2] and tested
against Linux v3.19-rc2.

[1] https://lkml.org/lkml/2012/4/23/516
[2] http://marc.info/?l=linux-kbuild&m=142022188322321&w=2

CC: Ben Hutchings <ben@decadent.org.uk>
CC: maximilian attems <max@stro.at>
CC: Thorsten Glaser <tg@debian.org>
CC: Alexander Wirt <formorer@debian.org>
CC: Michal Marek <mmarek@suse.cz>
CC: linux-kbuild@vger.kernel.org
Suggested-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 scripts/package/builddeb | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 5972624..be1f4d7 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -217,9 +217,21 @@ else
 fi
 maintainer="$name <$email>"
 
+# Try to determine distribution
+codename=$(lsb_release --codename --short)
+if [ -n "$KDEB_CHANGELOG_DIST" ]; then
+        distribution=$KDEB_CHANGELOG_DIST
+elif [ -n "$codename" ]; then
+        distribution=$codename
+else
+        distribution="unstable"
+        echo "builddeb: Using default distribution of 'unstable' in the changelog"
+        echo "builddeb: Install lsb-release or set \$KDEB_CHANGELOG_DIST to change this"
+fi
+
 # Generate a simple changelog template
 cat <<EOF > debian/changelog
-linux-upstream ($packageversion) unstable; urgency=low
+linux-upstream ($packageversion) $distribution; urgency=low
 
   * Custom built Linux kernel.
 
-- 
2.2.1


             reply	other threads:[~2015-01-02 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02 20:14 Sedat Dilek [this message]
2015-01-02 20:21 ` [RFC] builddeb: Try to determine distribution maximilian attems
2015-01-02 20:29   ` Sedat Dilek
2015-01-02 20:24 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420229669-5550-1-git-send-email-sedat.dilek@gmail.com \
    --to=sedat.dilek@gmail.com \
    --cc=ben@decadent.org.uk \
    --cc=formorer@debian.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=max@stro.at \
    --cc=mmarek@suse.cz \
    --cc=tg@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox