Re: [PATCH v2 1/2] kconfig: don't silently ignore unhandled characters

[Paul Bolle <pebolle@tiscali.nl>]

On Fri, 2015-01-16 at 15:44 +0000, Jan Beulich wrote:
> At the very least we should tell people that waht they wrote is not
                                               what

> what the utility understands.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> v2: printf() -> fprintf(stderr, ) upon Paul Bolle's request. Replace
>     two instances of double backslash line continuations with single
>     ones in sound/soc/intel/Kconfig.
> ---
>  scripts/kconfig/zconf.l             |    7 +
>  scripts/kconfig/zconf.lex.c_shipped |  195 +++++++++++++++++++-----------------
>  sound/soc/intel/Kconfig             |    4 

I guess Michal would like to split the c_shipped changes in this patch
too. (I personally don't care.) And I think the sound/soc/intel/Kconfig
should be a separate patch. 

>  3 files changed, 115 insertions(+), 91 deletions(-)
> 
> --- 3.19-rc4-kconfig.orig/scripts/kconfig/zconf.l
> +++ 3.19-rc4-kconfig/scripts/kconfig/zconf.l
> @@ -141,7 +141,12 @@ n	[A-Za-z0-9_]
>  	}
>  	#.*	/* comment */
>  	\\\n	current_file->lineno++;
> -	.
> +	[[:blank:]]+
> +	.	{

(Side note: I can't read lex, so is there a reason the dot is on a new
line? And I'm lazy too: what happens if you drop "[[:blank:]]+". In
other words: why was it added?) 

> +		fprintf(stderr,
> +		        "%s:%d:warning: ignoring unsupported character '%c'\n",
> +		        zconf_curname(), zconf_lineno(), *yytext);
> +	}
>  	<<EOF>> {
>  		BEGIN(INITIAL);
>  	}

Thanks!


Paul Bolle