Re: [PATCH] Kconfig: drop bogus default values

Paul Bolle
2015-03-23T21:24:35Z

Hi Martin,

On Mon, 2015-03-23 at 22:08 +0100, Martin Walch wrote:
> On Thursday 12 March 2015 13:11:47 Paul Bolle wrote:
> Your memory is right.

That's nice to hear, but I'm pretty sure this never occurred to me.

> It is rarely used, but there is an application for
> using a plain "default n": to overwrite an existing other default value.
> Particularly in one special case this is desired: Let us say there is a
> symbol that may lack a visible prompt, but has the default value y set in
> a Kconfig file that is used across all architectures. If there is a single
> architecture that must have the default value n then it is possible to
> override the default y in the global file with a default n in the
> architecture specific file.
>
> A real world case is PCI_QUIRKS in the mainline kernel:
>
> init/Kconfig:1554: default y
> arch/s390/Kconfig:59: def_bool n
>
> When setting PCI!=n && EXPERT=n then on each architecture PCI_QUIRKS=y
> except on s390 where PCI_QUIRKS=n.

Good catch!

For the same effect, would it do to have
config PCI_QUIRKS
default y if !S390
[...]

in init/Kconfig?

Paul Bolle