linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Michal Marek <mmarek@suse.cz>,
	akpm@linux-foundation.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH] Support gcc 6 for building
Date: Thu, 16 Apr 2015 09:23:10 -0700	[thread overview]
Message-ID: <1429201390.2850.54.camel@perches.com> (raw)
In-Reply-To: <20150416155626.GT2366@two.firstfloor.org>

On Thu, 2015-04-16 at 17:56 +0200, Andi Kleen wrote:
> On Thu, Apr 16, 2015 at 09:57:48AM +0200, Michal Marek wrote:
> > On 2015-04-15 21:45, Andi Kleen wrote:
> > > From: Andi Kleen <ak@linux.intel.com>
> > > 
> > > gcc recently switched to a new version number scheme, where every version
> > > gets a new major version number. The current version is 5.x, the next 6.x, etc.
> > > 
> > > The gcc git repository trunk branch just switched to report 6.x for the next
> > > major release.
> > > 
> > > This breaks the way Linux selects compiler-gccX.h based on the major
> > > version. Every new version would require adding a new compiler-gccX.h file,
> > > which wouldn't really scale.
> > > 
> > > Let's assume that future gccs are fairly compatible (they are unlikely
> > > to break anything Linux is relying on). So we can just keep using
> > > compiler-gcc5.h, and select any specific differences with #if.
> > 
> > Good idea. With the new scheme, we could also merge back compiler-gcc5.h
> > and compiler-gcc4.h. The only difference is the KASAN_ABI_VERSION define.
> 
> Would be fine too. Are you doing that, or should I send a patch?

As compiler-gcc3.h is trivial, what about integrating
the whole thing into a single file and get rid of the
compiler-gcc<version>.h files?

That would deduplicate the __must_check and __used macros.

I added Sasha Levin to the cc's as he was the only
complainant the first time I suggested this.

https://lkml.org/lkml/2014/9/4/675


  reply	other threads:[~2015-04-16 16:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 19:45 [PATCH] Support gcc 6 for building Andi Kleen
2015-04-16  3:04 ` Segher Boessenkool
2015-04-16  7:57 ` Michal Marek
2015-04-16 15:56   ` Andi Kleen
2015-04-16 16:23     ` Joe Perches [this message]
2015-04-16 16:29       ` Andi Kleen
2015-04-16 20:31         ` [PATCH 0/2] Integrate compiler-gcc[345].h files into compiler-gcc.h Joe Perches
2015-04-16 20:31           ` [PATCH 1/2] compiler-gcc.h: Neatening Joe Perches
2015-04-16 20:44             ` Joe Perches
2015-04-16 20:31           ` [PATCH 2/2] compiler-gcc: Integrate the various compiler-gcc[345].h files Joe Perches
2015-04-20 21:17           ` [PATCH 0/2] Integrate compiler-gcc[345].h files into compiler-gcc.h Andrew Morton
2015-04-20 21:24             ` Andi Kleen
2015-04-16 20:13     ` [PATCH] Support gcc 6 for building Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429201390.2850.54.camel@perches.com \
    --to=joe@perches.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).