Re: [PATCH v4] deb-pkg: add source package

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On Tue, 2015-09-01 at 16:48 +0300, riku.voipio@linaro.org wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
> 
> Make deb-pkg build both source and binary package like make rpm-pkg does.
> For people who only need binary kernel package, there is now bindeb-pkg
> target, same target also used to build the .deb files if built from the
> source package using dpkg-buildpackage.
> 
> Generated source package will build the same kernel .config than what
> was available for make deb-pkg. The name of the source package can
> be set with SOURCENAME enviroment variable.

KDEB_SOURCENAME, not SOURCENAME.

> The source package is useful for GPL compliance, or for feeding to a
> automated debian package builder.
> 
> Cc: Chris J Arges <chris.j.arges@canonical.com>
> Cc: maximilian attems <maks@stro.at>
> Cc: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---
> v4 address Bens commends,
> - use src_tar function instead of git archive for kernel sources
> - move KDEB_SOURCENAME setting to Makefile so it can be passed to
>   src_tar
> - use a toplevel .config file instead of a copy in debian/control
> - defend against delete of debian/ in clean target
[...]
> @@ -391,4 +396,32 @@ EOF
>  > 	> create_package "$dbg_packagename" "$dbg_dir"
>  fi
>  
> +if [ "x$1" = "xdeb-pkg" ]
> +then
> +    cat < debian/rules
> +#!/usr/bin/make -f
> +
> +build:
> +> 	> \$(MAKE) sourcename=${sourcename} KDEB_PKGVERSION=${packageversion}

I don't think this needs to set any variables, though it shouldn't
hurt.

> +binary-arch:
> +	\$(MAKE) sourcename=${sourcename} KDEB_PKGVERSION=${packageversion} bindeb-pkg
[...]

Shouldn't this be setting KDEB_SOURCENAME, not sourcename?

Ben.

-- 
Ben Hutchings
Horngren's Observation:
                   Among economists, the real world is often a special case.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]