Re: [PATCH] kbuild: Do not use hyphen in exported variable name

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]

On Sun, 2017-04-23 at 15:47 +0900, Masahiro Yamada wrote:
[...]
> I tested dtbs_install once again by myself, but
> dtbinst-root is exported to the sub make
> and the vendor directories are created correctly.
> 
> 
> I checked the debian's forum you gave
> > References: https://bugs.debian.org/833561
> 
> In there, you mentioned:
> "This looks like a bug in make, but we can at least work around it by
> using a non-hyphenated variable name."
> 
> 
> Does this issue happen on a specific Make version?
> 
> I tested GNU make 3.81, 3.82, 4.0, 4.1, 4.2,
> but I was not hit by the problem.

I don't think this is make version dependent.  I can't reproduce the
issue today with make 4.1.  But I would have been using the same
version in August when I wrote that.

What more can I say?  Clearly the hyphenated variable gets passed to
the sub-make in most cases.  But it's not totally reliable because last
year it wasn't working for us.

> In the last post in the thread, you concluded:
> "We believe that the bug you reported is fixed in the latest version of
> linux, which is due to be installed in the Debian FTP archive."

I didn't write that, it's a standard message generated for bugs marked
as closed in a package changelog. :-)

> If so, why is this patch here?
> How is the dtbs_install procedure different in the Debian package?

This is the patch I applied to the package.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]