From: Ben Hutchings <ben@decadent.org.uk>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
debian-kernel <debian-kernel@lists.debian.org>
Subject: Re: [PATCH] kbuild: Do not use hyphen in exported variable name
Date: Sat, 19 Aug 2017 21:14:15 +0100 [thread overview]
Message-ID: <1503173655.3688.35.camel@decadent.org.uk> (raw)
In-Reply-To: <CAK7LNAQKFRLs9wvg7qdFM5245jqv-6qUhRgF-61qiO_PE-J6kQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
On Sun, 2017-08-20 at 02:37 +0900, Masahiro Yamada wrote:
[...]
> I did "grep SHELL" in kernel sources, but I could not
> find suspicious line.
>
>
> Is there anyone that sets SHELL
> in debian specific patches?
No, there isn't. But I finally worked out the trigger conditions:
1. Source directory name includes a shell special character. This is
true in Debian whenever we build a release candidate, because the
source directory is named after the package version, and we use ~ to
represent a pre-release version (e.g. 4.13~rc5 sorts before 4.13).
2. Object directory is outside the source directory, or at least two
levels below it (see the definition of srctree in the top level
Makefile). This is always true in Debian package builds.
Shell comamnds to reproduce this:
rsync --archive --exclude /.git/ . /tmp/linux~/
cd /tmp/linux~
make mrproper
make O=one/two ARCH=arm64 defconfig
make -C one/two ARCH=arm64 dtbs
make -C one/two ARCH=arm64 INSTALL_DTBS_PATH=dtbs~ dtbs_install
Ben.
--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-08-19 20:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 1:00 [PATCH] kbuild: Do not use hyphen in exported variable name Ben Hutchings
2017-04-18 4:44 ` Sam Ravnborg
2017-04-23 6:47 ` Masahiro Yamada
2017-04-23 7:23 ` Ben Hutchings
2017-04-30 14:14 ` Masahiro Yamada
2017-04-30 14:49 ` Ben Hutchings
2017-05-03 4:47 ` Masahiro Yamada
2017-08-19 1:13 ` Ben Hutchings
2017-08-19 17:37 ` Masahiro Yamada
2017-08-19 20:14 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503173655.3688.35.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=debian-kernel@lists.debian.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox