Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

Luc Van Oostenryck
2017-11-20T20:08:35Z

On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote:
>
> I'd be nice if people could just specify CHECK and CHECKFLAGS to run
> their favorite checker, but currently CHECKFLAGS seems hardwired for
> running sparse. So something liike
>
> make C=1 CHECK="scripts/checkpatch.pl" CHECKFLAGS="--quiet --file"
>
> fails when checkpatch is passed lots of arguments like -D__linux__
> -Dlinux -D__STDC__ . A little shell wrapper to grab the last argument
> in that long list is a workaround, but perhaps CHECKFLAGS should be
> made less sparse-specific?

It should be noted though that CHECKFLAGS contains very very few
sparse specific things. It's mainly flags for the compiler
coming from KBUILD_CFLAGS (which of course, sparse needs to
do its job properly).

-- Luc Van Oostenryck