Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

Luc Van Oostenryck
2017-11-20T21:22:55Z

On Mon, Nov 20, 2017 at 10:10:12PM +0100, Knut Omang wrote:
> On Mon, 2017-11-20 at 21:08 +0100, Luc Van Oostenryck wrote:
> >
> > It should be noted though that CHECKFLAGS contains very very few
> > sparse specific things. It's mainly flags for the compiler
> > coming from KBUILD_CFLAGS (which of course, sparse needs to
> > do its job properly).
>
> Yes, and we would want some arguments passed to checkpatch by default as well.
>
> A wrapper script (which by the way was what I started this with..)
> could of course solve this and other issues such as the ability
> to run multiple checkers, but I am not convinced that that would be
> less ugly?

A wrapper script is something else that need to be maintained
but of course, it's very flexible.
I don't have a strong opinion on this and prefer to let speak
the people who maintain kbuild.

Should it be possible to somehow keep the distinction between
the flags coming from KBUILD_CFLAGS and the pure CHECKFLAGS?

-- Luc Van Oostenryck