From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: stable@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Tom Stellar <tstellar@redhat.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Juergen Gross <jgross@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
acme@redhat.com, akataria@vmware.com, akpm@linux-foundation.org,
andrea.parri@amarulasolutions.com, ard.biesheuvel@linaro.org,
aryabinin@virtuozzo.com, astrachan@google.com,
boris.ostrovsky@oracle.com, brijesh.singh@amd.com,
caoj.fnst@cn.fujitsu.com, geert@linux-m68k.org,
ghackmann@google.com, jan.kiszka@siemens.com,
jarkko.sakkinen@linux.intel.com, joe@perches.com,
jpoimboe@redhat.com, keescook@google.com,
kirill.shutemov@linux.intel.com, kstewart@linuxfoundation.org,
linux-efi@vger.kernel.org, linux-kbuild@vger.kernel.org,
manojgupta@google.com, mawilcox@microsoft.com,
michal.lkml@markovi.net, mjg59@google.com, mka@chromium.org,
pombredanne@nexb.com, rientjes@google.com, rostedt@goodmis.org,
thomas.lendacky@amd.com, tweek@google.com,
virtualization@lists.linux-foundation.org, will.deacon@arm.com,
yamada.masahiro@socionext.com, Ingo Molnar <mingo@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4.4 018/107] x86/paravirt: Make native_save_fl() extern inline
Date: Sat, 25 Aug 2018 00:08:00 +0100 [thread overview]
Message-ID: <1535152080.2902.58.camel@codethink.co.uk> (raw)
In-Reply-To: <20180723122413.797031305@linuxfoundation.org>
On Mon, 2018-07-23 at 14:41 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Nick Desaulniers <ndesaulniers@google.com>
>
> commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 upstream.
>
> native_save_fl() is marked static inline, but by using it as
> a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined.
>
> paravirt's use of native_save_fl() also requires that no GPRs other than
> %rax are clobbered.
[...]
Shouldn't native_restore_fl() be changed similarly? You added an out-
of-line definition, but it doesn't seem like it will actually be used.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
next prev parent reply other threads:[~2018-08-25 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180723122413.003644357@linuxfoundation.org>
2018-07-23 12:41 ` [PATCH 4.4 018/107] x86/paravirt: Make native_save_fl() extern inline Greg Kroah-Hartman
2018-08-24 23:08 ` Ben Hutchings [this message]
2018-08-27 21:06 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535152080.2902.58.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=acme@redhat.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=andrea.parri@amarulasolutions.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=astrachan@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=geert@linux-m68k.org \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgross@suse.com \
--cc=joe@perches.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manojgupta@google.com \
--cc=mawilcox@microsoft.com \
--cc=michal.lkml@markovi.net \
--cc=mingo@kernel.org \
--cc=mjg59@google.com \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=torvalds@linux-foundation.org \
--cc=tstellar@redhat.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox