public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kbuild: fix adjust_autoksyms.sh for modules that need only one symbol
@ 2016-04-28 21:33 Nicolas Pitre
  2016-04-28 21:49 ` Arnd Bergmann
  2016-05-10 15:25 ` Michal Marek
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Pitre @ 2016-04-28 21:33 UTC (permalink / raw)
  To: Michal Marek; +Cc: Arnd Bergmann, linux-kbuild

When only one symbol was listed and therefore the line didn't contain
any space to separate multiple symbols, that symbol got ignored.

Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Nicolas Pitre <nico@linaro.org>

diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
index 5bf538f1ed..8dc1918b67 100755
--- a/scripts/adjust_autoksyms.sh
+++ b/scripts/adjust_autoksyms.sh
@@ -59,7 +59,7 @@ cat > "$new_ksyms_file" << EOT
  */
 
 EOT
-sed -ns -e '3s/ /\n/gp' "$MODVERDIR"/*.mod | sort -u |
+sed -ns -e '3{s/ /\n/g;/^$/!p;}' "$MODVERDIR"/*.mod | sort -u |
 while read sym; do
 	if [ -n "$CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX" ]; then
 		sym="${sym#_}"

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: fix adjust_autoksyms.sh for modules that need only one symbol
  2016-04-28 21:33 [PATCH] kbuild: fix adjust_autoksyms.sh for modules that need only one symbol Nicolas Pitre
@ 2016-04-28 21:49 ` Arnd Bergmann
  2016-05-10 15:25 ` Michal Marek
  1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-04-28 21:49 UTC (permalink / raw)
  To: Nicolas Pitre; +Cc: Michal Marek, linux-kbuild

On Thursday 28 April 2016 17:33:38 Nicolas Pitre wrote:
> When only one symbol was listed and therefore the line didn't contain
> any space to separate multiple symbols, that symbol got ignored.
> 
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
> 
> 

Tested-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild: fix adjust_autoksyms.sh for modules that need only one symbol
  2016-04-28 21:33 [PATCH] kbuild: fix adjust_autoksyms.sh for modules that need only one symbol Nicolas Pitre
  2016-04-28 21:49 ` Arnd Bergmann
@ 2016-05-10 15:25 ` Michal Marek
  1 sibling, 0 replies; 3+ messages in thread
From: Michal Marek @ 2016-05-10 15:25 UTC (permalink / raw)
  To: Nicolas Pitre; +Cc: Arnd Bergmann, linux-kbuild

On Thu, Apr 28, 2016 at 05:33:38PM -0400, Nicolas Pitre wrote:
> When only one symbol was listed and therefore the line didn't contain
> any space to separate multiple symbols, that symbol got ignored.
> 
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>

Applied to kbuild.git#kbuild.

Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-10 15:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-28 21:33 [PATCH] kbuild: fix adjust_autoksyms.sh for modules that need only one symbol Nicolas Pitre
2016-04-28 21:49 ` Arnd Bergmann
2016-05-10 15:25 ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox