From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.13]:55108 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392AbcHKMk0 (ORCPT ); Thu, 11 Aug 2016 08:40:26 -0400 From: Arnd Bergmann Subject: [PATCH] Xen: remove -fshort-wchar gcc flag Date: Thu, 11 Aug 2016 14:39:50 +0200 Message-ID: <16541778.WMH6K24aDt@wuerfel> In-Reply-To: <1470910580-18458-1-git-send-email-npiggin@gmail.com> References: <1470910580-18458-1-git-send-email-npiggin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Nicholas Piggin Cc: linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, Michal Marek , Sam Ravnborg , Stephen Rothwell , Nicolas Pitre , Segher Boessenkool , Alan Modra , Boris Ostrovsky , David Vrabel , Juergen Gross , xen-devel@lists.xenproject.org A previous patch added the --no-wchar-size-warning to the Makefile to avoid this harmless warning: arm-linux-gnueabi-ld: warning: drivers/xen/efi.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail Changing kbuild to use thin archives instead of recursive linking unfortunately brings the same warning back during the final link. This time, we remove the -fshort-wchar flag that originally caused the warning, hopefully fixing the problem for good. I don't see any reason for having the flag in the first place, as the Xen code does not use wchar_t at all. Signed-off-by: Arnd Bergmann Fixes: 971a69db7dc0 ("Xen: don't warn about 2-byte wchar_t in efi") --- On Thursday, August 11, 2016 8:16:14 PM CEST Nicholas Piggin wrote: > Hi, > > I would like to submit the kbuild changes in patches 1-3 for > consideration. > > I've taken on the feedback, so thanks everybody for that. The > biggest change since last time is a more general way for > architectures to do a post-link pass in patch 3. > > On the question of whether to enable thin archives unconditionally, > I prefer to have architectures enable them as they are tested. But > I would like to see everybody moved as soon as possible and the > incremental linking removed. It would be nice to get this patch merged along with the thin archive conversion, either by merging it through the xen Tree, or by making it part of Nick's series with an Ack from the xen maintainers. diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 8feab810aed9..7f188b8d0c67 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -7,9 +7,6 @@ obj-y += xenbus/ nostackp := $(call cc-option, -fno-stack-protector) CFLAGS_features.o := $(nostackp) -CFLAGS_efi.o += -fshort-wchar -LDFLAGS += $(call ld-option, --no-wchar-size-warning) - dom0-$(CONFIG_ARM64) += arm-device.o dom0-$(CONFIG_PCI) += pci.o dom0-$(CONFIG_USB_SUPPORT) += dbgp.o