From: Arnd Bergmann <arnd@arndb.de>
To: James Hogan <james.hogan@imgtec.com>
Cc: Michal Marek <mmarek@suse.com>,
linux-kernel@vger.kernel.org,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@imgtec.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH v2 2/2] kbuild: Remove stale asm-generic wrappers
Date: Tue, 19 Jan 2016 15:09:14 +0100 [thread overview]
Message-ID: <1667268.iM977TQnEK@wuerfel> (raw)
In-Reply-To: <1453210670-12596-3-git-send-email-james.hogan@imgtec.com>
On Tuesday 19 January 2016 13:37:50 James Hogan wrote:
> When a header file is removed from generic-y (often accompanied by the
> addition of an arch specific header), the generated wrapper file will
> persist, and in some cases may still take precedence over the new arch
> header.
>
> For example commit f1fe2d21f4e1 ("MIPS: Add definitions for extended
> context") removed ucontext.h from generic-y in arch/mips/include/asm/,
> and added an arch/mips/include/uapi/asm/ucontext.h. The continued use of
> the wrapper when reusing a dirty build tree resulted in build failures
> in arch/mips/kernel/signal.c:
>
> arch/mips/kernel/signal.c: In function ‘sc_to_extcontext’:
> arch/mips/kernel/signal.c:142:12: error: ‘struct ucontext’ has no member named ‘uc_extcontext’
> return &uc->uc_extcontext;
> ^
>
> Fix by detecting and removing wrapper headers in generated header
> directories that do not correspond to a filename in generic-y, genhdr-y,
> or the newly introduced generated-y.
Good idea.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Can you merge this through the mips tree, or do you need me to pick it
up through asm-generic?
next prev parent reply other threads:[~2016-01-19 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 13:37 [PATCH v2 0/2] kbuild: Remove stale asm-generic wrappers James Hogan
2016-01-19 13:37 ` [PATCH v2 1/2] kbuild, x86: Track generated headers with generated-y James Hogan
2016-01-19 13:37 ` [PATCH v2 2/2] kbuild: Remove stale asm-generic wrappers James Hogan
2016-01-19 14:09 ` Arnd Bergmann [this message]
2016-01-19 14:22 ` James Hogan
2016-01-19 14:27 ` Arnd Bergmann
2016-02-23 9:51 ` James Hogan
2016-04-21 18:44 ` James Hogan
2016-01-20 18:55 ` Florian Fainelli
2016-01-21 0:03 ` Paul Burton
2016-01-21 10:19 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667268.iM977TQnEK@wuerfel \
--to=arnd@arndb.de \
--cc=f.fainelli@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mmarek@suse.com \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox