From: Nathan Chancellor <nathan@kernel.org>
To: 14侯廷翰 <ue081723@gmail.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
llvm@lists.linux.dev, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH] clang-tools: Import os for broken pipe handling
Date: Tue, 29 Sep 2026 21:59:52 +0200 [thread overview]
Message-ID: <179071199261.2735405.15944114878466249879.b4-reply@b4> (raw)
In-Reply-To: <CA+NtrhRdnuZOOFpBXvnfOXFs-HA8q+2sLvR0BxH=BjzVAEZBzw@mail.gmail.com>
On 2026-09-26 08:52 +0800, 14侯廷翰 wrote:
> From: Ting-Han Hou <ue081723@gmail.com>
>
> The BrokenPipeError handler in run-clang-tools.py calls os.open() and
> os.dup2() without importing os. If this handler is reached, it raises
> NameError instead of redirecting stdout and exiting with status 1.
>
> Import os so the handler can work as intended.
>
> Fixes: 87c7ee67deb7 ("scripts: handle BrokenPipeError for python scripts")
> Assisted-by: LLM
> Signed-off-by: Ting-Han Hou <ue081723@gmail.com>
> ---
> scripts/clang-tools/run-clang-tools.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/clang-tools/run-clang-tools.py
> b/scripts/clang-tools/run-clang-tools.py
Your patch is mangled, so it cannot be applied (maybe you send it with a
different client from your v1?). Please resend properly.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-09-29 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 14:22 [PATCH] clang-tools: Import os for broken pipe handling houtinghang
2026-09-25 22:34 ` Nathan Chancellor
2026-09-26 0:52 ` 14侯廷翰
2026-09-29 19:59 ` Nathan Chancellor [this message]
2026-09-30 7:58 ` Ting-Han Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179071199261.2735405.15944114878466249879.b4-reply@b4 \
--to=nathan@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=nsc@kernel.org \
--cc=ue081723@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox