From: Sam Ravnborg <sam@ravnborg.org>
To: EGRY Gabor <gaboregry1@t-online.hu>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel@zh-kernel.org
Subject: Re: [PATCH] kconfig: multibyte character support for lxdialog
Date: Sat, 12 Jan 2008 14:58:47 +0100 [thread overview]
Message-ID: <20080112135847.GA3580@uranus.ravnborg.org> (raw)
In-Reply-To: <1200139315.2785.2.camel@localhost.localdomain>
On Sat, Jan 12, 2008 at 01:01:55PM +0100, EGRY Gabor wrote:
>
> UTF-8 support for lxdialog with wchar. The installed wide ncurses (ncursesw) is optional.
Building this on my 64 bit box with ncursesw support I saw several warnings.
Adding the following to dialog.h decreased the number:
#ifdef USE_WIDE_CURSES
#define _XOPEN_SOURCE_EXTENDED
#endif
But it was not warning free.
In addition in your patch below you assume that
ncurses wide char support and wide char support follows each other.
This assumption makes things overly complicated.
Can we assume we have wide char support everywhere today where
we will support building Linux?
I am mostly concerned about sun, cygwin and MingW here...
If we can assume wide char support everywhere your patch will
become simplerAnd adding wide char support should be a separate step.
I tried to take a look at varous source packages and they do not
need this long list of redefinitions of the ncurses functions.
Do we do something fundamentally different than for example
dialog since this indirection is needed?
Sam
prev parent reply other threads:[~2008-01-12 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 12:01 [PATCH] kconfig: multibyte character support for lxdialog EGRY Gabor
2008-01-12 13:58 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080112135847.GA3580@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gaboregry1@t-online.hu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kernel@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox