Re: shell command is empty, when "silent" (Re: make V=1 broken)

[Oleg Verych <olecom@flower.upol.cz>]

On Mon, Feb 11, 2008 at 02:34:53PM +0100, Sam Ravnborg wrote:
> On Mon, Feb 11, 2008 at 03:46:40AM +0100, Oleg Verych wrote:
[]
> > ,--`make V=1`--
> > |  GEN     /dev/shm/blinux/Makefile
> > |set -e; ; mkdir -p include/linux/; 
> > []
> > |/bin/sh: Syntax error: ";" unexpected
> > `--
> > 
> > That "silent" juggling with `echo` is overhead, thus remove it.
> 
> Hi Oleg.
> People has requested to make the build even more silent with
> make -s. So when Mike provided a patch is was applied (but unfortunately faulty).
> 
> So I fixed it by appended patch.
> The right fix would have been to resue echo-cmd but that
> required a bit more rework.
[]

Memory is cheap, efficiency is uselsess.

Funny, that *debug* output didn't give a clue for quite some people.

Aah, why do i care?

>  #   to specify a valid file as first prerequisite (often the kbuild file)
> +       chk_filechk = :
>   quiet_chk_filechk = echo '  CHK     $@'
>  silent_chk_filechk = :
> +       upd_filechk = :
>   quiet_upd_filechk = echo '  UPD     $@'
>  silent_upd_filechk = :
> +
>  define filechk
>  	$(Q)set -e;				\
>  	$($(quiet)chk_filechk);			\
> -- 
> 1.5.4.rc3.14.g44397
>