[PATCH] Disable modpost warnings for linkonce sections

[PATCH] Disable modpost warnings for linkonce sections

[Andi Kleen]

Disable modpost warnings for linkonce sections

My build gives lots of warnings like

WARNING: sound/core/snd.o (.gnu.linkonce.wi.mpspec_def.h.30779716): unexpected section name.
The (.[number]+) following section name are ld generated and not expected.
Did you forget to use "ax"/"aw" in a .S file?
Note that for example <linux/init.h> contains
section definitions for use in .S files.

But for .linkonce. duplicated sections are actually ok and expected.
So just disable the warning for this case.

Signed-off-by: Andi Kleen <ak@linux.intel.com>

Index: linux/scripts/mod/modpost.c
===================================================================
--- linux.orig/scripts/mod/modpost.c
+++ linux/scripts/mod/modpost.c
@@ -721,7 +721,7 @@ static int check_section(const char *mod
 		/* consume all digits */
 		while (*e && e != sec && isdigit(*e))
 			e--;
-		if (*e == '.') {
+		if (*e == '.' && !strstr(sec, ".linkonce")) {
 			warn("%s (%s): unexpected section name.\n"
 			     "The (.[number]+) following section name are "
 			     "ld generated and not expected.\n"

Re: [PATCH] Disable modpost warnings for linkonce sections

[Sam Ravnborg]

On Thu, May 08, 2008 at 01:41:11PM +0200, Andi Kleen wrote:
> Disable modpost warnings for linkonce sections
> 
> My build gives lots of warnings like
> 
> WARNING: sound/core/snd.o (.gnu.linkonce.wi.mpspec_def.h.30779716): unexpected section name.
> The (.[number]+) following section name are ld generated and not expected.
> Did you forget to use "ax"/"aw" in a .S file?
> Note that for example <linux/init.h> contains
> section definitions for use in .S files.
> 
> But for .linkonce. duplicated sections are actually ok and expected.
> So just disable the warning for this case.

Agreed.
Applied and pushed out.

	Sam

Re: [PATCH] Disable modpost warnings for linkonce sections

[Andi Kleen]

Sam Ravnborg wrote:
> On Thu, May 08, 2008 at 01:41:11PM +0200, Andi Kleen wrote:
>> Disable modpost warnings for linkonce sections
>>
>> My build gives lots of warnings like
>>
>> WARNING: sound/core/snd.o (.gnu.linkonce.wi.mpspec_def.h.30779716): unexpected section name.
>> The (.[number]+) following section name are ld generated and not expected.
>> Did you forget to use "ax"/"aw" in a .S file?
>> Note that for example <linux/init.h> contains
>> section definitions for use in .S files.
>>
>> But for .linkonce. duplicated sections are actually ok and expected.
>> So just disable the warning for this case.
> 
> Agreed.
> Applied and pushed out.

There's still the "crap in /proc/kallsyms" problem like

0000000000000b0c N DW.aio.h.903a6d92.0
0000000000000b19 N DW.aio.h.903a6d92.1
0000000000000b24 N DW.aio.h.903a6d92.2
0000000000000bce N DW.task_io_accounting.h.8d8de327.0

Haven't not looked at that yet, but that needs to be fixed too.

-Andi