From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, pq@iki.fi, proski@gnu.org,
sandmann@redhat.com, a.p.zijlstra@chello.nl,
linux-kbuild@vger.kernel.org, zippel@linux-m68k.org,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 1/4] kbuild: Create new CFLAGS_REMOVE_(basename).o option
Date: Wed, 14 May 2008 21:30:29 -0400 [thread overview]
Message-ID: <20080515013705.027387767@goodmis.org> (raw)
In-Reply-To: 20080515013028.056366414@goodmis.org
[-- Attachment #1: kbuild-add-cflags-remove.patch --]
[-- Type: text/plain, Size: 1851 bytes --]
We currently have a way to add special CFLAGS to code, but we do not have a
way to remove them if needed.
With the case of ftrace, some files should simply not be profiled. Adding
the -pg flag to these files is simply a waste, and adding "notrace" to each
and every function is ugly.
Currently we put in "Makefile turd" [1] to stop the compiler from adding -pg
to certain files. This was clumsy and awkward.
This patch now adds the revese of CFLAGS_(basename).o with
CFLAGS_REMOVE_(basename).o. This allows developers to prevent certain
CFLAGS from being used to compile files. For example, we can now do
CFLAGS_REMOVE_string.o = -pg
to remove the -pg option from the string.o file in the lib directory.
Note: a space delimited list of options may be added to the REMOVE macro.
[1] - what David Miller called the workaronud to remove -pg
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
scripts/Makefile.lib | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-sched-devel.git/scripts/Makefile.lib
===================================================================
--- linux-sched-devel.git.orig/scripts/Makefile.lib 2008-05-14 18:12:22.000000000 -0700
+++ linux-sched-devel.git/scripts/Makefile.lib 2008-05-14 18:12:26.000000000 -0700
@@ -96,7 +96,8 @@ basename_flags = -D"KBUILD_BASENAME=KBUI
modname_flags = $(if $(filter 1,$(words $(modname))),\
-D"KBUILD_MODNAME=KBUILD_STR($(call name-fix,$(modname)))")
-_c_flags = $(KBUILD_CFLAGS) $(ccflags-y) $(CFLAGS_$(basetarget).o)
+orig_c_flags = $(KBUILD_CFLAGS) $(ccflags-y) $(CFLAGS_$(basetarget).o)
+_c_flags = $(filter-out $(CFLAGS_REMOVE_$(basetarget).o), $(orig_c_flags))
_a_flags = $(KBUILD_AFLAGS) $(asflags-y) $(AFLAGS_$(basetarget).o)
_cpp_flags = $(KBUILD_CPPFLAGS) $(cppflags-y) $(CPPFLAGS_$(@F))
--
next prev parent reply other threads:[~2008-05-15 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 1:30 [PATCH 0/4] Create a CFLAGS_REMOVE for ftrace Steven Rostedt
2008-05-15 1:30 ` Steven Rostedt [this message]
2008-05-15 1:30 ` [PATCH 2/4] ftrace: use the new kbuild CFLAGS_REMOVE for kernel directory Steven Rostedt
2008-05-15 1:30 ` [PATCH 3/4] ftrace: use the new kbuild CFLAGS_REMOVE for lib directory Steven Rostedt
2008-05-15 1:30 ` [PATCH 4/4] ftrace: use the new kbuild CFLAGS_REMOVE for x86/kernel directory Steven Rostedt
2008-05-15 9:02 ` [PATCH 0/4] Create a CFLAGS_REMOVE for ftrace Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515013705.027387767@goodmis.org \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=davem@davemloft.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pq@iki.fi \
--cc=proski@gnu.org \
--cc=sandmann@redhat.com \
--cc=srostedt@redhat.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox