From: Andrew Morton <akpm@linux-foundation.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: kbuild devel list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] KBUILD: Move non-__KERNEL__-checking headers to header-y.
Date: Tue, 20 May 2008 00:08:35 -0700 [thread overview]
Message-ID: <20080520000835.80f7b14a.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0805172016210.8908@localhost.localdomain>
On Sat, 17 May 2008 20:18:07 -0400 (EDT) "Robert P. J. Day" <rpjday@crashcourse.ca> wrote:
>
> Move exported header files under include/linux that don't check the
> __KERNEL__ preprocessor from unifdef-y to header-y.
>
Changelog fails to tell us why this change is being made.
Perhaps it's because these headers just don't need unifdef processing?
If so, that seems fragile. If we later add a __KERNEL__ section to a
header we need to remember to move the file to unifdef-y, and we'll
forget. It'd be better to process all files with unifdef.
Or something. Or not.
next prev parent reply other threads:[~2008-05-20 7:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 0:18 [PATCH] KBUILD: Move non-__KERNEL__-checking headers to header-y Robert P. J. Day
2008-05-20 7:08 ` Andrew Morton [this message]
2008-05-21 8:36 ` Robert P. J. Day
2008-05-21 8:43 ` Andrew Morton
2008-05-21 9:00 ` David Woodhouse
2008-05-21 10:02 ` Adrian Bunk
2008-05-21 10:47 ` David Woodhouse
2008-05-21 17:41 ` [2.6 patch] run all userspace headers through unifdef Adrian Bunk
2008-05-22 6:22 ` Andrew Morton
2008-05-22 7:00 ` David Woodhouse
2008-05-22 7:08 ` Andrew Morton
2008-05-22 7:12 ` David Woodhouse
2008-05-22 7:28 ` Robert P. J. Day
2008-05-22 7:37 ` Adrian Bunk
2008-05-22 7:08 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080520000835.80f7b14a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox