Re: [PATCH] KBUILD: Move non-__KERNEL__-checking headers to header-y.

Robert P. J. Day
2008-05-21T08:36:35Z

On Tue, 20 May 2008, Andrew Morton wrote:

> On Sat, 17 May 2008 20:18:07 -0400 (EDT) "Robert P. J. Day" <rpjday@crashcourse.ca> wrote:
>
> >
> > Move exported header files under include/linux that don't check the
> > __KERNEL__ preprocessor from unifdef-y to header-y.
> >
>
> Changelog fails to tell us why this change is being made.
>
> Perhaps it's because these headers just don't need unifdef processing?
>
> If so, that seems fragile. If we later add a __KERNEL__ section to
> a header we need to remember to move the file to unifdef-y, and
> we'll forget. It'd be better to process all files with unifdef.
>
> Or something. Or not.

i don't see a problem with simply running all exported files through
unifdef -- i've never understood the two categories since the unifdef
process is not exactly CPU-intensive and it can't possibly hurt for
some of those operations to be redundant.

but as long as the two categories exist, might as well keep them
clean.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================