From: Andrew Morton <akpm@linux-foundation.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Roman Zippel <zippel@linux-m68k.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [RFC PATCH] kconfig: introduce KCONFIG_* symbols for .c files
Date: Sat, 24 May 2008 13:48:15 -0700 [thread overview]
Message-ID: <20080524134815.116feb9d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080524202427.GA879@uranus.ravnborg.org>
On Sat, 24 May 2008 22:24:27 +0200 Sam Ravnborg <sam@ravnborg.org> wrote:
> > It could help to get us out of the occasional sticky situation, but it
> > does seem a bit risky. What happens with Kconfig variables which are
> > just not known about at all with some .configs?
> >
> > Silly example, one could add
> >
> > if (KCONFIG_DVB_VES1820)
> >
> > to kernel/sched.c and that would work happily until someone sets DVB=n,
> > in which case I assume KCONFIG_DVB_VES1820 doesn't get defined
> > anywhere?
> It would have helped if I had applied the correct patch...
> All boolean and tristate symbols in the konfiguration have
> their symbols defined as KCONFIG_* no matter their values.
> So KCONFIG_DVB_VES1820 would get defined.
But there are still holes - KCONFIG_ARCH_FOOTBRIDGE wouldn't be defined
on x86, for example. Anything which is inside an `if' or inside an
if/source/endif will not be known about? I assume?
It's all probably not a big problem in practice - we'd need to be
more-than-usually-silly to trip over things like this.
next prev parent reply other threads:[~2008-05-24 20:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-24 19:25 [RFC PATCH] kconfig: introduce KCONFIG_* symbols for .c files Sam Ravnborg
2008-05-24 19:53 ` Andrew Morton
2008-05-24 20:14 ` Jeremy Fitzhardinge
2008-05-24 20:46 ` Sam Ravnborg
2008-05-24 20:56 ` Jeremy Fitzhardinge
2008-05-24 21:03 ` Sam Ravnborg
2008-05-24 20:24 ` Sam Ravnborg
2008-05-24 20:48 ` Andrew Morton [this message]
2008-05-24 21:00 ` Sam Ravnborg
2008-05-24 20:05 ` Adrian Bunk
2008-05-24 20:44 ` Sam Ravnborg
2008-05-24 20:57 ` Adrian Bunk
2008-05-24 20:20 ` Linus Torvalds
2008-05-24 20:37 ` [PATCH] x86: use defconfig as last resort Sam Ravnborg
2008-05-25 1:30 ` Linus Torvalds
2008-05-25 6:15 ` Sam Ravnborg
2008-05-25 6:22 ` Sam Ravnborg
2008-05-24 20:48 ` [RFC PATCH] kconfig: introduce KCONFIG_* symbols for .c files Jeremy Fitzhardinge
2008-05-24 20:58 ` Jeremy Fitzhardinge
2008-05-24 21:03 ` Adrian Bunk
2008-05-24 21:13 ` Jeremy Fitzhardinge
2008-05-24 21:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080524134815.116feb9d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox