Re: [PATCH] x86: use defconfig as last resort

Sam Ravnborg
2008-05-25T06:14:49Z

On Sat, May 24, 2008 at 06:30:40PM -0700, Linus Torvalds wrote:
>
>
> On Sat, 24 May 2008, Sam Ravnborg wrote:
> >
> > When using "make oldconfig" with no .config
> > present try the list from init/Kconfig DEFCONFIG_LIST
> > before resorting to use one of the defconfigs.
>
> Hmm. Why does placement matter here?

We have the following list in init/Kconfig:

config DEFCONFIG_LIST
string
depends on !UML
option defconfig_list
default "/lib/modules/$UNAME_RELEASE/.config"
default "/etc/kernel-config"
default "/boot/config-$UNAME_RELEASE"
default "arch/$ARCH/defconfig"

If we define an arch specific DEFCONFIG_LIST before this then
the arch supplied values are tried first.
The patch moves the ARCH supplied list below the definition
in init/Kconfig so it is tried last.

>
> Also:
>
> > +config DEFCONFIG_LIST
> > + string
> > + depends on X86_32
> > + option defconfig_list
> > + default "arch/x86/configs/i386_defconfig"
> > +
> > +config DEFCONFIG_LIST
> > + string
> > + depends on X86_64
> > + option defconfig_list
> > + default "arch/x86/configs/x86_64_defconfig"
> > +
>
> Wouldn't this be cleaner as just *one* entry, and then just have
> different default statements, ie something like

I will try to come up with an alternative solution in a minute.

Sam