public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: kbuild devel list <linux-kbuild@vger.kernel.org>
Subject: Re: 'make arch/x86/' fails
Date: Tue, 27 May 2008 21:24:34 +0200	[thread overview]
Message-ID: <20080527192434.GA6433@uranus.ravnborg.org> (raw)
In-Reply-To: <19f34abd0805271201g587a2e8w4379f3d3f20f2cfa@mail.gmail.com>

On Tue, May 27, 2008 at 09:01:45PM +0200, Vegard Nossum wrote:
> On Tue, May 27, 2008 at 8:44 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> > On Tue, May 27, 2008 at 08:14:31PM +0200, Vegard Nossum wrote:
> >> Hi,
> >>
> >> I don't know if this is a regression or what (I've observed it for a
> >> while), but now I thought I'd let you know about it:
> >>
> >> $ make arch/x86/
> >>   CHK     include/linux/version.h
> >>   CHK     include/linux/utsrelease.h
> >>   CC      kernel/bounds.s
> >>   GEN     include/linux/bounds.h
> >>   CC      arch/x86/kernel/asm-offsets.s
> >>   GEN     include/asm-x86/asm-offsets.h
> >>   CALL    scripts/checksyscalls.sh
> >> [...]/linux-2.6/arch/x86/Makefile:37: *** Recursive variable
> >> `KBUILD_CFLAGS' references itself (eventually).  Stop.
> >> make: *** [arch/x86/] Error 2
> >
> > This is unfortunately what you should expect
> > because the directory arch/x86/ is special as it does
> > not contain a regular Kbuild file but instead contains
> > a badly named arch configuration file (Makefile).
> >
> >>
> >> Are there any work-arounds or easy fixes for this? Thanks.
> > For each directory in arch/x86/* do make arch/x86/{directory}
> >
> 
> Thanks.
> 
> How about splitting a part of arch/*/Makefile into
> arch/*/Makefile.arch and including this new Makefile.arch from the
> top-level Makefile instead?
> 
> -include $(srctree)/arch/$(SRCARCH)/Makefile
> +include $(srctree)/arch/$(SRCARCH)/Makefile.arch

I have looked into doing this in a clean way.
But in the end I always stumbled over something for
one of the archs and then I dropped it again.
The purpose of splitting it up should be to simplify
the top-level Makefile and enabling make arch/x86/ would
be a nice sideeffect.

	Sam

      reply	other threads:[~2008-05-27 19:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-27 18:14 'make arch/x86/' fails Vegard Nossum
2008-05-27 18:44 ` Sam Ravnborg
2008-05-27 19:01   ` Vegard Nossum
2008-05-27 19:24     ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080527192434.GA6433@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox