'make arch/x86/' fails

'make arch/x86/' fails

[Vegard Nossum]

Hi,

I don't know if this is a regression or what (I've observed it for a
while), but now I thought I'd let you know about it:

$ make arch/x86/
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CC      kernel/bounds.s
  GEN     include/linux/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
  GEN     include/asm-x86/asm-offsets.h
  CALL    scripts/checksyscalls.sh
[...]/linux-2.6/arch/x86/Makefile:37: *** Recursive variable
`KBUILD_CFLAGS' references itself (eventually).  Stop.
make: *** [arch/x86/] Error 2

Are there any work-arounds or easy fixes for this? Thanks.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036

Re: 'make arch/x86/' fails

[Sam Ravnborg]

On Tue, May 27, 2008 at 08:14:31PM +0200, Vegard Nossum wrote:
> Hi,
> 
> I don't know if this is a regression or what (I've observed it for a
> while), but now I thought I'd let you know about it:
> 
> $ make arch/x86/
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   CC      kernel/bounds.s
>   GEN     include/linux/bounds.h
>   CC      arch/x86/kernel/asm-offsets.s
>   GEN     include/asm-x86/asm-offsets.h
>   CALL    scripts/checksyscalls.sh
> [...]/linux-2.6/arch/x86/Makefile:37: *** Recursive variable
> `KBUILD_CFLAGS' references itself (eventually).  Stop.
> make: *** [arch/x86/] Error 2

This is unfortunately what you should expect
because the directory arch/x86/ is special as it does
not contain a regular Kbuild file but instead contains
a badly named arch configuration file (Makefile).

> 
> Are there any work-arounds or easy fixes for this? Thanks.
For each directory in arch/x86/* do make arch/x86/{directory}

	Sam

Re: 'make arch/x86/' fails

[Vegard Nossum]

On Tue, May 27, 2008 at 8:44 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Tue, May 27, 2008 at 08:14:31PM +0200, Vegard Nossum wrote:
>> Hi,
>>
>> I don't know if this is a regression or what (I've observed it for a
>> while), but now I thought I'd let you know about it:
>>
>> $ make arch/x86/
>>   CHK     include/linux/version.h
>>   CHK     include/linux/utsrelease.h
>>   CC      kernel/bounds.s
>>   GEN     include/linux/bounds.h
>>   CC      arch/x86/kernel/asm-offsets.s
>>   GEN     include/asm-x86/asm-offsets.h
>>   CALL    scripts/checksyscalls.sh
>> [...]/linux-2.6/arch/x86/Makefile:37: *** Recursive variable
>> `KBUILD_CFLAGS' references itself (eventually).  Stop.
>> make: *** [arch/x86/] Error 2
>
> This is unfortunately what you should expect
> because the directory arch/x86/ is special as it does
> not contain a regular Kbuild file but instead contains
> a badly named arch configuration file (Makefile).
>
>>
>> Are there any work-arounds or easy fixes for this? Thanks.
> For each directory in arch/x86/* do make arch/x86/{directory}
>

Thanks.

How about splitting a part of arch/*/Makefile into
arch/*/Makefile.arch and including this new Makefile.arch from the
top-level Makefile instead?

-include $(srctree)/arch/$(SRCARCH)/Makefile
+include $(srctree)/arch/$(SRCARCH)/Makefile.arch

(I know you're busy these days, but do you think I would waste my time
in pursuing this any further? :-))


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036

Re: 'make arch/x86/' fails

[Sam Ravnborg]

On Tue, May 27, 2008 at 09:01:45PM +0200, Vegard Nossum wrote:
> On Tue, May 27, 2008 at 8:44 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> > On Tue, May 27, 2008 at 08:14:31PM +0200, Vegard Nossum wrote:
> >> Hi,
> >>
> >> I don't know if this is a regression or what (I've observed it for a
> >> while), but now I thought I'd let you know about it:
> >>
> >> $ make arch/x86/
> >>   CHK     include/linux/version.h
> >>   CHK     include/linux/utsrelease.h
> >>   CC      kernel/bounds.s
> >>   GEN     include/linux/bounds.h
> >>   CC      arch/x86/kernel/asm-offsets.s
> >>   GEN     include/asm-x86/asm-offsets.h
> >>   CALL    scripts/checksyscalls.sh
> >> [...]/linux-2.6/arch/x86/Makefile:37: *** Recursive variable
> >> `KBUILD_CFLAGS' references itself (eventually).  Stop.
> >> make: *** [arch/x86/] Error 2
> >
> > This is unfortunately what you should expect
> > because the directory arch/x86/ is special as it does
> > not contain a regular Kbuild file but instead contains
> > a badly named arch configuration file (Makefile).
> >
> >>
> >> Are there any work-arounds or easy fixes for this? Thanks.
> > For each directory in arch/x86/* do make arch/x86/{directory}
> >
> 
> Thanks.
> 
> How about splitting a part of arch/*/Makefile into
> arch/*/Makefile.arch and including this new Makefile.arch from the
> top-level Makefile instead?
> 
> -include $(srctree)/arch/$(SRCARCH)/Makefile
> +include $(srctree)/arch/$(SRCARCH)/Makefile.arch

I have looked into doing this in a clean way.
But in the end I always stumbled over something for
one of the archs and then I dropped it again.
The purpose of splitting it up should be to simplify
the top-level Makefile and enabling make arch/x86/ would
be a nice sideeffect.

	Sam