From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3.mail.elte.hu ([157.181.1.138]:32936 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbYGAGlg (ORCPT ); Tue, 1 Jul 2008 02:41:36 -0400 Date: Tue, 1 Jul 2008 08:41:22 +0200 From: Ingo Molnar Subject: Re: [PATCH 21/24] kconfig: prefix hex values with 0x in .config Message-ID: <20080701064122.GE16642@elte.hu> References: <20080630213155.GA32479@uranus.ravnborg.org> <1214861718-32626-21-git-send-email-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1214861718-32626-21-git-send-email-sam@ravnborg.org> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Sam Ravnborg Cc: kbuild , lkml , Roman Zippel * Sam Ravnborg wrote: > We could hit a situation where hex values > are stored internally in kconfig without 0x prefix, so if we see > one of these add 0x prefix when we write value to .config. > The real fix is to make sure we always prefix hex > values with 0x in kconfig. > > Signed-off-by: Sam Ravnborg > Cc: Roman Zippel > --- > arch/x86/boot/compressed/relocs.c | 2 +- > scripts/kconfig/confdata.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/boot/compressed/relocs.c b/arch/x86/boot/compressed/relocs.c > index edaadea..88d27f6 100644 > --- a/arch/x86/boot/compressed/relocs.c > +++ b/arch/x86/boot/compressed/relocs.c > @@ -244,7 +244,7 @@ static void read_ehdr(FILE *fp) > static void read_shdrs(FILE *fp) > { > int i; > - if (ehdr.e_shnum > MAX_SHDRS) { > + if (1 || ehdr.e_shnum > MAX_SHDRS) { > die("%d section headers supported: %d\n", > ehdr.e_shnum, MAX_SHDRS); > } note: stale x86 change slipped into this patch, please do not commit it to the kbuild tree. (i suspect it happened when you sent me the MAX_SHDRS debug patch yesterday) Ingo