* [PATCH] Change Kbuild message to match default
@ 2008-07-15 22:31 jkacur
2008-07-26 9:34 ` John Kacur
0 siblings, 1 reply; 5+ messages in thread
From: jkacur @ 2008-07-15 22:31 UTC (permalink / raw)
To: sam; +Cc: linux-kbuild
Change the Kbuild "If unsure" message to match the default.
Signed-off-by: John Kacur <jkacur at gmail dot com>
Index: linux-2.6.26/init/Kconfig
===================================================================
--- linux-2.6.26.orig/init/Kconfig
+++ linux-2.6.26/init/Kconfig
@@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE
Enabling this option will pass "-Os" instead of "-O2" to gcc
resulting in a smaller kernel.
- If unsure, say N.
+ If unsure, say Y.
config SYSCTL
bool
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Change Kbuild message to match default 2008-07-15 22:31 [PATCH] Change Kbuild message to match default jkacur @ 2008-07-26 9:34 ` John Kacur 2008-07-30 20:26 ` Sam Ravnborg 0 siblings, 1 reply; 5+ messages in thread From: John Kacur @ 2008-07-26 9:34 UTC (permalink / raw) To: sam; +Cc: linux-kbuild, lkml On Wed, Jul 16, 2008 at 12:31 AM, jkacur <jkacur@gmail.com> wrote: > Change the Kbuild "If unsure" message to match the default. > > Signed-off-by: John Kacur <jkacur at gmail dot com> > > Index: linux-2.6.26/init/Kconfig > =================================================================== > --- linux-2.6.26.orig/init/Kconfig > +++ linux-2.6.26/init/Kconfig > @@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE > Enabling this option will pass "-Os" instead of "-O2" to gcc > resulting in a smaller kernel. > > - If unsure, say N. > + If unsure, say Y. > > config SYSCTL > bool > This seems like a no-brainer to me that the default and the "If unsure" message should match, any reason you haven't picked-it up? Thanks John Kacur ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Change Kbuild message to match default 2008-07-26 9:34 ` John Kacur @ 2008-07-30 20:26 ` Sam Ravnborg 2008-07-30 23:23 ` John Kacur 0 siblings, 1 reply; 5+ messages in thread From: Sam Ravnborg @ 2008-07-30 20:26 UTC (permalink / raw) To: John Kacur; +Cc: linux-kbuild, lkml On Sat, Jul 26, 2008 at 11:34:14AM +0200, John Kacur wrote: > On Wed, Jul 16, 2008 at 12:31 AM, jkacur <jkacur@gmail.com> wrote: > > Change the Kbuild "If unsure" message to match the default. > > > > Signed-off-by: John Kacur <jkacur at gmail dot com> > > > > Index: linux-2.6.26/init/Kconfig > > =================================================================== > > --- linux-2.6.26.orig/init/Kconfig > > +++ linux-2.6.26/init/Kconfig > > @@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE > > Enabling this option will pass "-Os" instead of "-O2" to gcc > > resulting in a smaller kernel. > > > > - If unsure, say N. > > + If unsure, say Y. > > > > config SYSCTL > > bool > > > > This seems like a no-brainer to me that the default and the "If > unsure" message should match, any reason you haven't picked-it up? Two reasons: 1) I have not started to look at new patches until now And this is due to several reasons. First off I have been without internet for a while. And secondly I do try to avoid new patches during the merge window which does not fix merge issues. 2) I am not convinced that "default y" is really what we want. What does popular distroes use (aka what gets wide testing?). Sam ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Change Kbuild message to match default 2008-07-30 20:26 ` Sam Ravnborg @ 2008-07-30 23:23 ` John Kacur 2008-07-31 21:34 ` Sam Ravnborg 0 siblings, 1 reply; 5+ messages in thread From: John Kacur @ 2008-07-30 23:23 UTC (permalink / raw) To: Sam Ravnborg; +Cc: linux-kbuild, LKML On Wed, Jul 30, 2008 at 10:26 PM, Sam Ravnborg <sam@ravnborg.org> wrote: > On Sat, Jul 26, 2008 at 11:34:14AM +0200, John Kacur wrote: >> On Wed, Jul 16, 2008 at 12:31 AM, jkacur <jkacur@gmail.com> wrote: >> > Change the Kbuild "If unsure" message to match the default. >> > >> > Signed-off-by: John Kacur <jkacur at gmail dot com> >> > >> > Index: linux-2.6.26/init/Kconfig >> > =================================================================== >> > --- linux-2.6.26.orig/init/Kconfig >> > +++ linux-2.6.26/init/Kconfig >> > @@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE >> > Enabling this option will pass "-Os" instead of "-O2" to gcc >> > resulting in a smaller kernel. >> > >> > - If unsure, say N. >> > + If unsure, say Y. >> > >> > config SYSCTL >> > bool >> > >> >> This seems like a no-brainer to me that the default and the "If >> unsure" message should match, any reason you haven't picked-it up? > > Two reasons: > > 1) I have not started to look at new patches until now > > And this is due to several reasons. > First off I have been without internet for a while. > And secondly I do try to avoid new patches during the > merge window which does not fix merge issues. Ok, no problem! > > 2) I am not convinced that "default y" is really what we want. > What does popular distroes use (aka what gets wide testing?). > Hmnn, good point, in any case there is an inconsistency here. I can only speak for my laptop here running openSUSE 11.0 (X86-64) gunzip -c /proc/config.gz | grep CC_OPTIMIZE_FOR_SIZE CONFIG_CC_OPTIMIZE_FOR_SIZE=y uname -a Linux linux-ipxk 2.6.25.11-0.1-default #1 SMP 2008-07-13 20:48:28 +0200 x86_64 x86_64 x86_64 GNU/Linux ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Change Kbuild message to match default 2008-07-30 23:23 ` John Kacur @ 2008-07-31 21:34 ` Sam Ravnborg 0 siblings, 0 replies; 5+ messages in thread From: Sam Ravnborg @ 2008-07-31 21:34 UTC (permalink / raw) To: John Kacur; +Cc: linux-kbuild, LKML On Thu, Jul 31, 2008 at 01:23:56AM +0200, John Kacur wrote: > On Wed, Jul 30, 2008 at 10:26 PM, Sam Ravnborg <sam@ravnborg.org> wrote: > > On Sat, Jul 26, 2008 at 11:34:14AM +0200, John Kacur wrote: > >> On Wed, Jul 16, 2008 at 12:31 AM, jkacur <jkacur@gmail.com> wrote: > >> > Change the Kbuild "If unsure" message to match the default. > >> > > >> > Signed-off-by: John Kacur <jkacur at gmail dot com> > >> > > >> > Index: linux-2.6.26/init/Kconfig > >> > =================================================================== > >> > --- linux-2.6.26.orig/init/Kconfig > >> > +++ linux-2.6.26/init/Kconfig > >> > @@ -522,7 +522,7 @@ config CC_OPTIMIZE_FOR_SIZE > >> > Enabling this option will pass "-Os" instead of "-O2" to gcc > >> > resulting in a smaller kernel. > >> > > >> > - If unsure, say N. > >> > + If unsure, say Y. > >> > > >> > config SYSCTL > >> > bool > >> > > >> > >> This seems like a no-brainer to me that the default and the "If > >> unsure" message should match, any reason you haven't picked-it up? > > > > Two reasons: > > > > 1) I have not started to look at new patches until now > > > > And this is due to several reasons. > > First off I have been without internet for a while. > > And secondly I do try to avoid new patches during the > > merge window which does not fix merge issues. > > Ok, no problem! > > > > > 2) I am not convinced that "default y" is really what we want. > > What does popular distroes use (aka what gets wide testing?). > > > > Hmnn, good point, in any case there is an inconsistency here. I can > only speak for my laptop here running openSUSE 11.0 (X86-64) > > gunzip -c /proc/config.gz | grep CC_OPTIMIZE_FOR_SIZE > CONFIG_CC_OPTIMIZE_FOR_SIZE=y > uname -a > Linux linux-ipxk 2.6.25.11-0.1-default #1 SMP 2008-07-13 20:48:28 > +0200 x86_64 x86_64 x86_64 GNU/Linux Thanks - I applied your patch. Sam ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-31 21:33 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-07-15 22:31 [PATCH] Change Kbuild message to match default jkacur 2008-07-26 9:34 ` John Kacur 2008-07-30 20:26 ` Sam Ravnborg 2008-07-30 23:23 ` John Kacur 2008-07-31 21:34 ` Sam Ravnborg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox