From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpout3.tre.se ([80.251.192.228]:30064 "EHLO smtpout3.tre.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbYGaUQO (ORCPT ); Thu, 31 Jul 2008 16:16:14 -0400 Date: Thu, 31 Jul 2008 22:16:02 +0200 From: Sam Ravnborg Subject: Re: [Patch] UML build: fix missing posix_types.h Message-ID: <20080731201602.GC25158@uranus.ravnborg.org> References: <20080731121028.GA23636@hack.voiplan.pt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080731121028.GA23636@hack.voiplan.pt> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: WANG Cong Cc: LKML , jdike@addtoit.com, linux-kbuild@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, Andrew Morton On Thu, Jul 31, 2008 at 01:10:28PM +0100, WANG Cong wrote: > > When building UML with 'O=foo' specified, I got: > > CC kernel/bounds.s > In file included from > /home/wangcong/Projects/linux-2.6/include/linux/types.h:11, > from > /home/wangcong/Projects/linux-2.6/include/linux/page-flags.h:8, > from > /home/wangcong/Projects/linux-2.6/kernel/bounds.c:9: > /home/wangcong/Projects/linux-2.6/include/linux/posix_types.h:47:29: > error: asm/posix_types.h: No such file or directory > In file included from > /home/wangcong/Projects/linux-2.6/include/linux/page-flags.h:8, > from > /home/wangcong/Projects/linux-2.6/kernel/bounds.c:9: > /home/wangcong/Projects/linux-2.6/include/linux/types.h:12:23: error: > asm/types.h: No such file or directory > In file included from > /home/wangcong/Projects/linux-2.6/include/linux/page-flags.h:8, > > Below patch fixed it, note, it is only tested for x86 and um. > > Signed-off-by: WANG Cong > Cc: sam@ravnborg.org > Cc: jdike@addtoit.com > > --- > diff --git a/Makefile b/Makefile > index aa527a4..39130d1 100644 > --- a/Makefile > +++ b/Makefile > @@ -930,7 +930,8 @@ ifneq ($(KBUILD_SRC),) > /bin/false; \ > fi; > $(Q)if [ ! -d include2 ]; then mkdir -p include2; fi; > - $(Q)if [ -e $(srctree)/include/asm-$(SRCARCH)/system.h ]; then \ > + $(Q)if [ -e $(srctree)/include/asm-$(SRCARCH)/system.h -o \ > + -e $(objtree)/include/asm-$(SRCARCH)/system.h ] ; then \ > ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm; \ > fi > endif I have a similar patch locally. I just check for errno.h so I do not have to do the extra check in objtree. Will push tonight. Sam