From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: zippel@linux-m68k.org, linux-kbuild@vger.kernel.org
Subject: Re: annoying "trying to assign nonexistent symbol" warnings
Date: Fri, 1 Aug 2008 21:38:07 +0200 [thread overview]
Message-ID: <20080801193807.GA4441@uranus.ravnborg.org> (raw)
In-Reply-To: <20080801192220.GB19682@cs181140183.pp.htv.fi>
On Fri, Aug 01, 2008 at 10:22:20PM +0300, Adrian Bunk wrote:
> Now that defconfig became less chatty the "trying to assign nonexistent symbol"
> warnings become annoying: They are in practice not avoidable and give a
> false impression that something would have gone wrong.
>
> If anyone already knows where to touch the code for disabling these
> warnings for defconfigs that would be appreciated, otherwise I'll cook
> up a patch.
Last time I posted a patch to remove these warnings the feedback was
that the warnings was used to say when a defconfig really needed an update.
And the patch was buried inside another serie so I dropped it again.
IIRC I added this warning long time ago and Roman was not happy
with it - and he was right then.
Sam
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 0759761..df6a188 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -222,10 +222,8 @@ load:
continue;
if (def == S_DEF_USER) {
sym = sym_find(line + 9);
- if (!sym) {
- conf_warning("trying to assign nonexistent symbol %s", line + 9);
+ if (!sym)
break;
- }
} else {
sym = sym_lookup(line + 9, 0);
if (sym->type == S_UNKNOWN)
@@ -261,10 +259,8 @@ load:
}
if (def == S_DEF_USER) {
sym = sym_find(line + 7);
- if (!sym) {
- conf_warning("trying to assign nonexistent symbol %s", line + 7);
+ if (!sym)
break;
- }
} else {
sym = sym_lookup(line + 7, 0);
if (sym->type == S_UNKNOWN)
next prev parent reply other threads:[~2008-08-01 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 19:22 annoying "trying to assign nonexistent symbol" warnings Adrian Bunk
2008-08-01 19:38 ` Sam Ravnborg [this message]
2008-08-04 21:09 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801193807.GA4441@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox