Re: [PATCH] ncurses based config V2

Nir Tzachar
2008-11-25T08:01:21Z

Hello Sam.

On Mon, Nov 24, 2008 at 8:44 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Nir.
>
> Some comments as followup to Willy.
>
>> OK, I've just tried it. Here are the first comments I can make :
>>
>> - colors are too dark.
> Seconded. Please try to find a lighter set of default colors.
> You may be inspired by one of the menuconfig color-sets.
>
> I agree that we could use a lift here - so please do not go for the
> default color set of menuconfig.

Personally, I like lighter text on a dark background. But this is just
me. I'll try to implement an easier color scheme chooser so everyone
will be able to play with it and come up with something they like.

>> - entering text in boxes (eg: local version) does not move the cursor,
>> it remains at the beginning of the line. If I press any arrow, the
>> box immediately closes (most likely the Esc prefix again).
>

This is fixed in my current version (I have not subitted a patch yet)

> I do not see any cursor which is annoying. menuconfig has the same issue.

also fixed.

>> - I noticed I was tempted a lot to press "?" to get help, but the key is
>> not bound. It would be nice to have it bound to Help since make oldconfig
>> and menuconfig to both report help that way.
>
> Please bound this.

consider it bounded..

>> - I'm not convinced that the parenthesis around hotkeys make the menu
>> that much readable, especially when there are lots of short words or
>> even acronyms. Eg :
>> [ ] (U)TS namespace
>> [ ] (I)PC namespace
>> [ ] (U)ser namespace (EXPERIMENTAL)
>> [ ] (P)ID Namespaces (EXPERIMENTAL)
>
> This looks like some ancient stuff and it must be a better way to
> show the short-cuts.

This was the best I could come up with, as ncurses does not let you
use color attributed for menu items. I'll try a different scheme,
where the first capitalized letter is the shortcut. What do u say?

> I would really appreciate if you could look into the above issues.
> If you do a repost with this fixed I will try to do a proper review,
> including code-review next time.

Sure. I'll have a patch ready in a few days.
Cheers.